Antlr4 performance workaround #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafeltra
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-1153.
Modifying the babel configuration and rebuilding antlr4 restores performance to an acceptable speed. This workaround can be removed when the configuration change is available in the official antlr4 package.
To test, change to the PR's branch, then run
npm packto create a.tgzfile for the package. Then, runnpm install -g <package-name>.tgzto globally install the package. This will add the workaround to your globally installed version of SUSHI. Then, go to any SUSHI project and build it. You should notice that the FSH text import is restored to an acceptable speed and is much faster than in v3.3.0. A test repo is available that clearly demonstrates the performance difference.