Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better antlr4 workaround #1325

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Better antlr4 workaround #1325

merged 2 commits into from
Aug 21, 2023

Conversation

mint-thompson
Copy link
Collaborator

@mint-thompson mint-thompson commented Aug 21, 2023 •
edited
Loading

The first workaround #1323 for fixing up antlr4 did not behave correctly under a variety of circumstances, such as when antlr4 was not contained within SUSHI's node_modules directory, or on linux/mac systems. This workaround is more consistent, and should work regardless of OS or other installed packages.

jafeltra
jafeltra approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous workaround did work on my Mac but didn't work well when things in node_modules weren't where they were expected. This workaround still works on my Mac and seems to be working better in FSH Online. Yay!

@mint-thompson mint-thompson merged commit 754a4ed into master Aug 21, 2023
14 checks passed
@mint-thompson mint-thompson deleted the better-antlr4-workaround branch August 21, 2023 16:26
@mint-thompson mint-thompson mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafeltra jafeltra jafeltra approved these changes

@cmoesel cmoesel Awaiting requested review from cmoesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mint-thompson @jafeltra