Full functional #138
Merged
Full functional #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ACat701
commented
May 11, 2024
ACat701
commented
- Hood and Shooter still aren't functional
- Turret only has manual movement
…ffbot_Code into full-functional
TaylerUva
approved these changes
May 11, 2024
Comment on lines
149
to
162
| conOperator.POV_North | ||
| .onTrue(Commands.runOnce(() -> subShooter.setGoalSpeed(prefPreset.presetFenderShooterSpeed))) | ||
| // .onTrue(Commands.runOnce(() -> | ||
| // subShooter.setGoalSpeed(prefPreset.presetFenderShooterSpeed))) | ||
| .onTrue(Commands.runOnce(() -> subHood.setAngle(prefPreset.presetFenderHoodDegrees))); | ||
|
|
||
| conOperator.POV_South | ||
| .onTrue(Commands.runOnce(() -> subShooter.setGoalSpeed(prefPreset.presetLaunchpadShooterSpeed))) | ||
| // .onTrue(Commands.runOnce(() -> | ||
| // subShooter.setGoalSpeed(prefPreset.presetLaunchpadShooterSpeed))) | ||
| .onTrue(Commands.runOnce(() -> subHood.setAngle(prefPreset.presetLaunchpadHoodDegrees))); | ||
|
|
||
| conOperator.POV_West | ||
| .onTrue(Commands.runOnce(() -> subShooter.setGoalSpeed(prefPreset.presetTarmacShooterSpeed))) | ||
| // .onTrue(Commands.runOnce(() -> | ||
| // subShooter.setGoalSpeed(prefPreset.presetTarmacShooterSpeed))) | ||
| .onTrue(Commands.runOnce(() -> subHood.setAngle(prefPreset.presetTarmacHoodDegrees))); |
There was a problem hiding this comment.
Remove hood presets in another PR
Comment on lines
+112
to
+115
| public static final SN_DoublePreference shooterF = new SN_DoublePreference("shooterF", 0); | ||
| public static final SN_DoublePreference shooterP = new SN_DoublePreference("shooterP", 1); | ||
| public static final SN_DoublePreference shooterI = new SN_DoublePreference("shooterI", 0); | ||
| public static final SN_DoublePreference shooterD = new SN_DoublePreference("shooterD", 0); |
There was a problem hiding this comment.
Are these being used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.