Fix for issue #407: Prevent crashes due to unbounded growth.

[navarchus]

Prevent crashes due to unbounded growth of a few items.

Fixes #407.

[navarchus]

Special thanks to @walksanatora for helping me learn the repo

[vgskye]

shouldn't this use the limit at https://github.com/FallingColors/HexMod/blob/main/Common/src/main/java/at/petrak/hexcasting/common/lib/hex/HexIotaTypes.java#L26?

[navarchus]

shouldn't this use the limit at https://github.com/FallingColors/HexMod/blob/main/Common/src/main/java/at/petrak/hexcasting/common/lib/hex/HexIotaTypes.java#L26?

I believe this is a different enough scenario, as the bug in question is about a spell which continually adds to a list whereas the constants you reference seem to be more related to trying to limit the max size of a spell before it is cast.

[vgskye]

shouldn't this use the limit at main/Common/src/main/java/at/petrak/hexcasting/common/lib/hex/HexIotaTypes.java#L26?

I believe this is a different enough scenario, as the bug in question is about a spell which continually adds to a list whereas these constants seem to be more related to trying to limit the max size of a spell before it is cast.

I believe the MAX_SERIALIZATION_TOTAL limit is commonly known as iota limit or serialization limit, which.... limits hexes in much the same way as this pull in practice, so I feel like treating this limit as an extension of that is reasonable.
(also it'd let you reuse IotaType.isTooLargeToSerialize for checking)

[object-Object]

Looks good. It would be nice if the error message showed the pattern that caused it, but I'll do that myself later. Thanks for the PR!