WIP: New vector interpolations and mappings #798
Conversation
… error though (test fails)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 93.57% 89.40% -4.18%
==========================================
Files 39 42 +3
Lines 6073 6739 +666
==========================================
+ Hits 5683 6025 +342
- Misses 390 714 +324 ☔ View full report in Codecov by Sentry. |
src/FEValues/EdgeValues.jl
Outdated
There was a problem hiding this comment.
Can we put this feature (+ tests) in a separate PR?
There was a problem hiding this comment.
Yes, it will.
Sorry that didn't update much on the plan with this PR, but it will need to be split into several sub-PRs. However, it is easier to work with the full one, and it can also serve as a reference when reviewing the sub-PRs later.
| @@ -49,3 +49,24 @@ dofs defined on a specific entity. Hence, not overloading of the dof functions w | |||
| element with zero dofs. Also, it should always be double checked that everything is consistent as | |||
| specified in the docstring of the corresponding function, as inconsistent implementations can | |||
| lead to bugs which are really difficult to track down. | |||
|
|
|||
| ## Vector interpolation properties | |||
| ### Hdiv interpolations | |||
There was a problem hiding this comment.
| ### Hdiv interpolations | |
| ### H(div) interpolations |
There was a problem hiding this comment.
It might make sense to add some comments about the De-Rahm complex here for readers not familiar with the topic.
Implements Hcurl (Nedelec) and Hdiv (RaviartThomas and BrezziDouglasMarini) interpolations and the associated mappings.
To ensure that the infrastructure works well, I would aim to have the following here
Finalization plan
The diff is too large for effective review, so this PR should not be merged, but I will split it into several smaller PRs.