bugfix Flipboard/bottomsheet#134 #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -716,7 +716,6 @@ public void onAnimationEnd(Animator animation) { | |||
| // Remove sheet specific properties | |||
| viewTransformer = null; | |||
| onSheetDismissedListeners.clear(); | |||
| onSheetStateChangeListeners.clear(); | |||
There was a problem hiding this comment.
I think this makes sense. We'll have to update the documentation to make it clear that callers need to remove their listeners. We should also mention that in the change log.
|
@odyodyodys will you work on this? |
|
We could fold this in as part of #122 if I could get some reviewers |
|
@meierjan not at the moment sorry but is there more to do? For me this 1 line change is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #134 that makes it impossible to attach state handlers to the later view when switching bottomsheet views (calling
showWithSheetViewwhen there is already a view in peek or expanded states)