Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix Flipboard/bottomsheet#134 #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix Flipboard/bottomsheet#134 #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bottomsheet/src/main/java/com/flipboard/bottomsheet/BottomSheetLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,6 @@ public void onAnimationEnd(Animator animation) {
// Remove sheet specific properties
viewTransformer = null;
onSheetDismissedListeners.clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the behavior of onSheetDismissedListeners and onSheetStateChangeListeners the same for this, and also not clear onSheetDismissedListeners.

onSheetStateChangeListeners.clear();
if (runAfterDismiss != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. We'll have to update the documentation to make it clear that callers need to remove their listeners. We should also mention that in the change log.

runAfterDismiss.run();
runAfterDismiss = null;
Expand Down