Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Catalogues & NPM configuration file for Devices #3588

Closed
Tracked by #3172
MarianRaphael opened this issue Mar 18, 2024 · 8 comments · Fixed by #3643 or FlowFuse/device-agent#246
Closed
Tracked by #3172

Node Catalogues & NPM configuration file for Devices #3588

MarianRaphael opened this issue Mar 18, 2024 · 8 comments · Fixed by #3643 or FlowFuse/device-agent#246
Assignees
Labels
headline Something to highlight in the release size:M - 3 Sizing estimation point story A user-oriented description of a feature
Milestone

Comments

@MarianRaphael
Copy link
Contributor

MarianRaphael commented Mar 18, 2024

Epic

#3172

Description

As a FlowFuse user who works with devices,

I want to be able to configure the .npmrc file and Node Catalogues within FlowFuse,

So that I have the flexibility to include my own external npm modules and integrate the Auth Dashboard plugin seamlessly into my development environment.

Which customers would this be availble to

Team + Enterprise Tiers (EE)

Acceptance Criteria

No response

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@MarianRaphael MarianRaphael added the story A user-oriented description of a feature label Mar 18, 2024
@MarianRaphael MarianRaphael moved this to Up Next in 🛠 Development Mar 18, 2024
@MarianRaphael MarianRaphael added headline Something to highlight in the release size:L - 5 Sizing estimation point size:M - 3 Sizing estimation point and removed size:L - 5 Sizing estimation point labels Mar 18, 2024
@hardillb
Copy link
Contributor

npmrc files and catalogue.json are already included in the settings pushed to a device that is bound to an Instance.

So does this only apply to Application bound instances?
If so then should this also include the other things we need to be able to configure for an Application bound device e.g.

  • Node-RED Version

@hardillb hardillb moved this from Up Next to In Design in 🛠 Development Mar 19, 2024
@hardillb hardillb self-assigned this Mar 19, 2024
@hardillb
Copy link
Contributor

Correction, .npmrc file and catalogue.json are added if they are contained in a snapshot.

The only way to get them into a snapshot is currently if the snapshot comes from an Instance where they have been configured.

@hardillb
Copy link
Contributor

We need to decide what should take priority here. Should a device be allowed to set it's own .npmrc file that overrides the one in the snapshot?

@MarianRaphael
Copy link
Contributor Author

So does this only apply to Application bound instances?

Yes

Should a device be allowed to set it's own .npmrc file that overrides the one in the snapshot?

Yes in Dev Mode

@MarianRaphael
Copy link
Contributor Author

If so then should this also include the other things we need to be able to configure for an Application bound device e.g.

Node-RED Version

See #2802 a potential follow-up item

@hardillb
Copy link
Contributor

hardillb commented Mar 20, 2024

Should a device be allowed to set it's own .npmrc file that overrides the one in the snapshot?

Yes in Dev Mode

That will prove very difficult. Devices would need to be restarted for this to take effect.

@MarianRaphael
Copy link
Contributor Author

Devices would need to be restarted for this to take effect.

Which isn't a big deal since #3292 right? It should be now more or less like for an hosted instance

@Steve-Mcl Steve-Mcl moved this from Review to Needs Verification in 🛠 Development Apr 10, 2024
@Steve-Mcl
Copy link
Contributor

Verified in pre-staging instance

@Steve-Mcl Steve-Mcl moved this from Needs Verification to Verified in 🛠 Development Apr 10, 2024
@joepavitt joepavitt moved this from Verified to Done in 🛠 Development Apr 30, 2024
@joepavitt joepavitt added this to the 2.3 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
headline Something to highlight in the release size:M - 3 Sizing estimation point story A user-oriented description of a feature
Projects
Archived in project
Status: Done
4 participants