Add catalogue and npmrc to App bound instances #246
Conversation
| if (this.project) { | ||
| if (this.snapshot.settings?.palette?.npmrc) { | ||
| await fs.writeFile(this.files.npmrc, this.snapshot.settings.palette.npmrc) | ||
| } else { | ||
| if (existsSync(this.files.npmrc)) { | ||
| await fs.rm(this.files.npmrc) | ||
| } | ||
| } | ||
| } else if (this.application) { | ||
| if (this.settings.palette?.npmrc) { | ||
| await fs.writeFile(this.files.npmrc, this.settings.palette.npmrc) | ||
| } else { | ||
| if (existsSync(this.files.npmrc)) { | ||
| await fs.rm(this.files.npmrc) | ||
| } |
There was a problem hiding this comment.
Unsure why snapshot is not considered when application bound?
I may need to pull and test locally to do this pair of PRs any justice.
I have another PR to review and my own PR to adjust all within the next 1h30m - i may not get this done today (sorry Ben)
There was a problem hiding this comment.
Hi @Steve-Mcl I'm trying to get the Forge app side of this fixed up today, can you finish looking at this bit as well please
There was a problem hiding this comment.
Discussed the question around whether the palette catalogues/npmrc settings should be part of snapshot in Eng meeting (alongside the up-coming work around providing settings for Node-RED version (for application assigned devices) and its need to be included in the snapshot)
As it stands, this work will permit the goal of providing catalogues and npmrc but may need to be "handled" when devices are more closely aligned with instances.
Approved as is
Part of FlowFuse/flowfuse#3588
Description
Allows catalogue.json URLs and .npmrc to be set for a Application bound Device
Paired with FlowFuse/flowfuse#3643
Related Issue(s)
FlowFuse/flowfuse#3588
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel