Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .npmrc and calalogue urls to be set for Application bound devices #3643

Merged
merged 13 commits into from
Apr 10, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Mar 26, 2024

part of #3588

Description

Allow the setting of .npmrc and extra catalogue.json URLs for application bound instances

image

Has pair PR on the device agent: FlowFuse/device-agent#246

Related Issue(s)

#3588

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Mar 26, 2024
@hardillb hardillb added this to the 2.3 milestone Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 41.72%. Comparing base (72da25e) to head (1197d80).
Report is 10 commits behind head on main.

Files Patch % Lines
frontend/src/pages/device/Settings/Palette.vue 0.00% 70 Missing ⚠️
frontend/src/pages/device/Settings/index.vue 0.00% 4 Missing ⚠️
frontend/src/pages/device/Settings/Environment.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   41.84%   41.72%   -0.13%     
==========================================
  Files         630      631       +1     
  Lines       24459    24533      +74     
  Branches     5993     6012      +19     
==========================================
+ Hits        10235    10236       +1     
- Misses      14224    14297      +73     
Flag Coverage Δ
backend 78.65% <ø> (+<0.01%) ⬆️
frontend 1.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb marked this pull request as ready for review March 27, 2024 14:25
@hardillb hardillb linked an issue Mar 27, 2024 that may be closed by this pull request
@hardillb hardillb requested a review from Steve-Mcl March 27, 2024 14:34
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion in vue (using old style props)

Since we are adding new data fields to the device API, I feel we should add unit tests for presence of settings.palette.npmrc and settings.palette.catalogues?

Lastly, sorry to bring up the dreaded docs - I fully appreciate there are no device specific docs (or to be more explicit no device-settings.md equivalent to instance-settings.md) but perhaps a nod to the feature could be made in the device section of concepts? i will leave that to you Ben.

frontend/src/pages/device/Settings/Palette.vue Outdated Show resolved Hide resolved
@Steve-Mcl
Copy link
Contributor

There is an issue when a non owner is logged. They see default palette settings due to guard in the API (only role.owner is provided settings).

image

@hardillb hardillb requested a review from Steve-Mcl April 8, 2024 09:57
@Steve-Mcl Steve-Mcl merged commit b5326bd into main Apr 10, 2024
9 of 10 checks passed
@Steve-Mcl Steve-Mcl deleted the device-npmrc-catalogue branch April 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Catalogues & NPM configuration file for Devices
3 participants