-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow .npmrc and calalogue urls to be set for Application bound devices #3643
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3643 +/- ##
==========================================
- Coverage 41.84% 41.72% -0.13%
==========================================
Files 630 631 +1
Lines 24459 24533 +74
Branches 5993 6012 +19
==========================================
+ Hits 10235 10236 +1
- Misses 14224 14297 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion in vue (using old style props)
Since we are adding new data fields to the device API, I feel we should add unit tests for presence of settings.palette.npmrc
and settings.palette.catalogues
?
Lastly, sorry to bring up the dreaded docs - I fully appreciate there are no device specific docs (or to be more explicit no device-settings.md
equivalent to instance-settings.md
) but perhaps a nod to the feature could be made in the device section of concepts? i will leave that to you Ben.
part of #3588
Description
Allow the setting of .npmrc and extra catalogue.json URLs for application bound instances
Has pair PR on the device agent: FlowFuse/device-agent#246
Related Issue(s)
#3588
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label