Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) : Add docker configuration for optimization #515

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(feat) : Add docker configuration for optimization #515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d0919
feat: Optimize Dockerfile with Nginx.
Suraj-kumar00 Oct 8, 2024
52be1bd
Update Dockerfile
Suraj-kumar00 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Stage 1: Build the application
FROM node:18-alpine AS build

# Setting up the working directory inside the container
WORKDIR /app

# Copy package.json and package-lock.json to the working directory
COPY package.json package-lock.json ./

# Install dependencies
RUN npm ci --production

# Copy the rest of the application code to the working directory
COPY . .

# Build the React application
RUN npm run build

# Stage 2: Serve the application
FROM nginx:alpine

# Copy built files from the previous stage
COPY --from=build /app/build /usr/share/nginx/html

# Expose the port the app runs on
EXPOSE 80

# Start the Nginx server
CMD ["nginx", "-g", "daemon off;"]
Comment on lines +20 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding a custom Nginx configuration

While the current setup will work for basic scenarios, you might want to consider adding a custom Nginx configuration to handle things like:

  • Routing for single-page applications (SPA)
  • Caching strategies
  • Security headers
  • Gzip compression

You can do this by creating a custom nginx.conf file and copying it into the image.

Here's a suggested addition:

 # Copy built files from the previous stage
 COPY --from=build /app/build /usr/share/nginx/html
 
+# Copy custom Nginx configuration
+COPY nginx.conf /etc/nginx/nginx.conf
+
 # Expose the port the app runs on
 EXPOSE 80
 
 # Start the Nginx server
 CMD ["nginx", "-g", "daemon off;"]

Then create a nginx.conf file in your project with the desired configuration.

Committable suggestion was skipped due to low confidence.