-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only store ctx
in handlers, frontends and passes
#2126
Open
oxisto
wants to merge
4
commits into
main
Choose a base branch
from
cb/no-ctx-in-node
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,113
−1,205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2326d82
to
6921e49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 115 out of 115 changed files in this pull request and generated no comments.
6921e49
to
17832c3
Compare
17832c3
to
90cbd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a HUGE breaking change in which we only make the
TranslationContext
available to handlers, frontends and passes. No storingctx
in the node any more - which had issues because we were not storing it correctly in ALL nodes.(Unfortunately) this also made a change in the
TypeManager
necessary: Instead of theregisterType
function (which was always error-prone), we gather our types in theTypeResolver
and store the information about (resolved) types in theTypeManager
. This also has the advantage that we are now resolving types of each component sequentially. Beforehand, we were trying to resolving all types in all components (which was unnecessary because they were already resolved) and the information to which component it belongs was lost.