Delete old stuff #467
Delete old stuff #467
Conversation
|
Terraform plan for tts-10x-forms-dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:8cb48332a7d7fa856009a2d3d06faeec6e087903" -> "ghcr.io/gsa-tts/forms/server-doj:19be7a968d8f29b9046c7f6224af1920904be9f0"
id = "29c93a0a-519c-454a-847e-cc603395c2da"
name = "tts-10x-forms-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #649 |
There was a problem hiding this comment.
The new workspace-dependencies.svg
Looks a little bit too clustered and hard to read.
Yeah, it's been bad for awhile. It used to be in the README and wasn't worth keeping. Maybe we just remove it? |
…e prioretize auto-generated docs in the future, we could revisit.
There was a problem hiding this comment.
we may also want to clean up this:
forms/packages/dependency-graph/src/index.ts
Lines 13 to 15 in 8cb4833
| ENV PNPM_HOME="/pnpm" | ||
| ENV PATH="$PNPM_HOME:$PATH" | ||
| ENV NODE_ENV=test | ||
| RUN apt-get -y update && apt-get install -y netcat-openbsd | ||
| RUN apt-get -y update && apt-get install -y netcat-openbsd make g++ |
There was a problem hiding this comment.
I ran this through hadolint and it said...
Dockerfile:6 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:6 DL3015 info: Avoid additional packages by specifying `--no-install-recommends`
Dockerfile:6 DL3009 info: Delete the apt-get lists after installing something
Dockerfile:16 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`
Dockerfile:21 DL3000 error: Use absolute WORKDIR
Just a comment, no need to respond or do anything.
There was a problem hiding this comment.
Thanks, I added a draft issue to track.
Remove unused packages.
This also revs the Playwright version, due to errors stemming from rebuilding the lockfile.