Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old stuff #467

Merged
merged 13 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/_validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
playwright_version:
description: Installed playwright version
required: false
default: "1.48.1"
default: '1.50.0'
type: string

jobs:
Expand Down Expand Up @@ -69,7 +69,6 @@ jobs:
- name: Make directory for build artifacts
run: mkdir -p output/build-artifacts


- name: Spotlight app performance budget
run: pnpm --filter @atj/spotlight size:ci > output/build-artifacts/spotlight-size-output.txt

Expand All @@ -95,7 +94,7 @@ jobs:
- name: Setup Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.10.4"
terraform_version: '1.10.4'

- name: Initialize Terraform CDK configuration
shell: bash
Expand Down
1 change: 0 additions & 1 deletion apps/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"test": "vitest run --coverage"
},
"dependencies": {
"@atj/dependency-graph": "workspace:*",
"@atj/infra-core": "workspace:*",
"commander": "^11.1.0"
}
Expand Down
9 changes: 0 additions & 9 deletions apps/cli/src/cli-controller/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Command } from 'commander';

import { createDependencyGraph } from '@atj/dependency-graph';
import type { Context } from './types.js';
import { addSecretCommands } from './secrets.js';

Expand All @@ -16,14 +15,6 @@ export const CliController = (ctx: Context) => {
ctx.console.log('Hello!');
});

cli
.command('create-workspace-graph')
.description('create a dependency graph of projects in the workspace')
.action(async () => {
await createDependencyGraph(ctx.workspaceRoot);
ctx.console.log('wrote workspace dependency graph');
});

addSecretCommands(ctx, cli);

return cli;
Expand Down
2 changes: 0 additions & 2 deletions apps/server-kansas/.gitignore

This file was deleted.

3 changes: 0 additions & 3 deletions apps/server-kansas/README.md

This file was deleted.

23 changes: 0 additions & 23 deletions apps/server-kansas/package.json

This file was deleted.

22 changes: 0 additions & 22 deletions apps/server-kansas/src/index.ts

This file was deleted.

27 changes: 0 additions & 27 deletions apps/server-kansas/src/server.ts

This file was deleted.

15 changes: 0 additions & 15 deletions apps/server-kansas/tests/integration.test.ts

This file was deleted.

12 changes: 0 additions & 12 deletions apps/server-kansas/tsconfig.json

This file was deleted.

4 changes: 2 additions & 2 deletions e2e/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# base image with Node.js and playwright preinstalled
FROM mcr.microsoft.com/playwright:v1.48.1-noble as base
FROM mcr.microsoft.com/playwright:v1.50.0-noble as base
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
ENV NODE_ENV=test
RUN apt-get -y update && apt-get install -y netcat-openbsd
RUN apt-get -y update && apt-get install -y netcat-openbsd make g++
Copy link

@wesley-dean-gsa wesley-dean-gsa Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this through hadolint and it said...

Dockerfile:6 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:6 DL3015 info: Avoid additional packages by specifying `--no-install-recommends`
Dockerfile:6 DL3009 info: Delete the apt-get lists after installing something
Dockerfile:16 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`
Dockerfile:21 DL3000 error: Use absolute WORKDIR

Just a comment, no need to respond or do anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added a draft issue to track.

WORKDIR /srv/apps/atj-platform
COPY ./pnpm-lock.yaml ./pnpm-lock.yaml
COPY ./package.json ./package.json
Expand Down
1 change: 0 additions & 1 deletion e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"test": "export E2E_ENDPOINT=http://localhost:4321; pnpm playwright test --ui-port=8080 --ui-host=0.0.0.0"
},
"devDependencies": {
"@playwright/test": "1.48.1",
"@storybook/test-runner": "^0.19.1",
"path-to-regexp": "^8.2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"pre-commit": "pnpm format"
},
"devDependencies": {
"@playwright/test": "^1.49.1",
"@playwright/test": "^1.50.0",
"@rollup/plugin-commonjs": "^28.0.2",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^16.0.0",
Expand Down
7 changes: 0 additions & 7 deletions packages-python/docassemble-server/Dockerfile

This file was deleted.

11 changes: 0 additions & 11 deletions packages-python/docassemble-server/README.md

This file was deleted.

13 changes: 0 additions & 13 deletions packages-python/docassemble-server/docker-compose.yml

This file was deleted.

8 changes: 0 additions & 8 deletions packages-python/docassemble-server/manifest.yml

This file was deleted.

1 change: 0 additions & 1 deletion packages/dependency-graph/.gitignore

This file was deleted.

15 changes: 0 additions & 15 deletions packages/dependency-graph/README.md

This file was deleted.

23 changes: 0 additions & 23 deletions packages/dependency-graph/package.json

This file was deleted.

36 changes: 0 additions & 36 deletions packages/dependency-graph/src/get-dependencies.ts

This file was deleted.

24 changes: 0 additions & 24 deletions packages/dependency-graph/src/graph-dependencies.ts

This file was deleted.

17 changes: 0 additions & 17 deletions packages/dependency-graph/src/index.ts

This file was deleted.

10 changes: 0 additions & 10 deletions packages/dependency-graph/tsconfig.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/design/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
}
],
"devDependencies": {
"@playwright/test": "1.48.1",
"@storybook/addon-a11y": "^8.4.7",
"@storybook/addon-coverage": "^1.0.5",
"@storybook/addon-essentials": "^8.4.7",
Expand Down
2 changes: 0 additions & 2 deletions packages/docassemble/.gitignore

This file was deleted.

11 changes: 0 additions & 11 deletions packages/docassemble/README.md

This file was deleted.

Loading