Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pollution fluid mechanic from ebf #3677

Merged
merged 17 commits into from
Jan 8, 2025

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Dec 20, 2024

Closes GTNewHorizons/GT-New-Horizons-Modpack#18038

This makes CO/CO2/SO2 output normally as a fluid regardless of muffler tier, as it is advertised in NEI, for example 3 cobaltite dust gives 1000 liters of sulfuric dioxide

This also removes the top casing limitation, since without this, no hatches other than muffler can go there.

@StaffiX StaffiX added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. Affects Balance Change affecting balance. Requires admin approval before merging. labels Dec 20, 2024
@StaffiX StaffiX requested a review from a team December 20, 2024 15:29
@YannickMG
Copy link
Contributor

It seems this is equivalent to installing a 100% efficient muffler on all EBFs in terms of that "get gases back" mechanic. Since that was already meant to be loop-free this is probably the best way to go about this change. It was weird that this was the only machine with this mechanic.

There's a world in which this mechanic could come back, but if it did we would need to much more clearly communicate in NEI which outputs are affected and by what coefficients.

@YannickMG
Copy link
Contributor

Regarding removing the top casing limitation that seems like that could be an unrelated change that deserves its own PR and discussion. When building an EBF it's annoying not to be able to use the top part for hatches, but at the same time it seems to me like it's a nice challenge to try and get the most out of the 8 casings of the bottom layer for all your I/O needs. If you remove that limitation, you're also removing this "mini automation challenge".

Also if top and bottom casings really become equivalent then probably swap out b in the structure for another letter, like h for hatches.

@YannickMG
Copy link
Contributor

The code looks good otherwise but this needs 2 separate balance approvals:

  • Unlinking CO/CO2/SO2 output from muffler tier
  • Doubling the allowed number of hatches on the EBF.

Copy link
Contributor

@YannickMG YannickMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke a bit too soon, we can clean up this class by removing methods which are now, or already were identical to the super class.

MTEElectricBlastFurnace::isCorrectMachinePart is also identical, for instance.

.withCount(t -> t.mPollutionOutputHatches.size()))
.casingIndex(CASING_INDEX)
.dot(1)
.buildAndChain(GregTechAPI.sBlockCasings1, CASING_INDEX))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will unform all the EBFs with an output hatch on top, which is quite a lot of unformed EBFs considering it's an LV multiblock. I want it so a single output hatch can be added on top in addition to the other one on the bottom, to avoid base breaking change and to allow for a bit more flexibility for those who want to use this additional hatch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't unform any ebfs, due to the changed structure definition, but I will revert it back if it's not something wanted even after adding a minimum casing limit (which I forgot EBF doesn't have)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want the ability to have one output hatch on top, just like before, but for all the fluid outputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, i added back the hatch restriction to the ebf (but i left the any casing for hatch for the mbf since it doesn't have the same logistical challenge to it).

So now it unforms if a bus or input hatch gets placed at the top, just like before.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 8, 2025
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 8, 2025
@Dream-Master Dream-Master enabled auto-merge (squash) January 8, 2025 12:33
@Dream-Master Dream-Master disabled auto-merge January 8, 2025 12:37
@Dream-Master Dream-Master merged commit ff0c88c into GTNewHorizons:master Jan 8, 2025
5 checks passed
@StaffiX StaffiX deleted the ebf branch January 12, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove pollution fluid hatches from the EBF
4 participants