Fixed glider requiring two clicks after scrolling away #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickMG
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
I'm glad someone tackled this. It works well in SP and MP.
I can't see an obvious issue with this approach. I do note the nature of the map is changing a lot but I also see that keeping the old map reintroduces the bug, but changing it is not sufficient to fix it.
Co-authored-by: Yannick Marcotte-Gourde <[email protected]>
|
This breaks the glider partly in multi-player. If you want to close the glider you NEED to scroll away to disable it. A simple click wouldn't disable it anymore what makes it harder to use. Had no time to troubleshoot myself yet, so I leave this here as comment for now. EDIT: Fix at #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The OpenBlocks Hang Glider closes when not in your hand anymore (e.g. when scrolling away). But after taking it into your hand again it requires two clicks to open again, instead of one. This happens to me in SP, but I see no reason why it shouldn't happen in MP too.
This happens because the
ItemHangGliderandEntityHangGliderclasses use two seperate static maps maintaining allEntityHangGliders in use right now and they did slightly different things. This change reduces this to a single map inEntityHangGliderand fixes the above issue.I believe Issue 16815 might also be fixed by this.
This is my first pull request, so if anything is unclear I'm happy to respond :)