fix glider won't close on right-click on dedicated server

[Pilzinsel64]

Fixes the glider never get closed on right-click in multiplayer. Reason is that it never get stored at the gliderMap on servers.

Due #25 the only point where it get written to the gliderMap is readSpawnData() wich is only executed on the client side.

Thsi PR adds another static method EntityHangGlider.SetEntityHangGlider(EntityPlayer, EntityHangGlider) and call it at ItemHangGlider.spawnGlider(). This works well in MP & SP.

(An alternative (and even easier) implentation would be adding the glider to the gliderMap on updateEntity(). But this doesn't work in SP.)

[Shaddaaa]

It seems like we were working on this issue at the same time, I came up with a different fix here.

Your fix basically makes the gliderMap publically accessible. I was trying to avoid that as the Code Style Guide explicitly advices against something like that, but I guess access through a setter is ok?

Edit: I was already writing a PR explaining my changes, might as well paste that here:

Issue: PR25 broke right click beeing able to close the hang glider, but only on dedicated servers.

I'm not a 100% confident in the cause of this, as I do not fully understand what is and is not synced between logical client and logical server and how this differs in the case of a SP world vs a dedicated server.
I believe this happens because readSpawnData is only run on the client and this is the only place we add the EntityHangGlider-instance to the map after PR25. I do not know, why this would only affect dedicated servers.
This change adds a gliderMap.put(...) to the server side to fix this issue.

Another issue then appears (only in SP): The glider floats way above the player, this seems to be usually fixed by the call to glider.fixPositions in updateGliders. But here the check depends on the type of EntityPlayer object. This might have also been broken by PR25. But as the whole updateGliders is @SideOnly(Side.CLIENT) it seems sensible to always hand over localPlayer=true in the glider.fixPositions call here and this change indeed fixes the issue.

I tested these changes in SP and on a dedicated server and everything remarked here and in PR25 now works as it should. Maybe someone with more indepth knowledge of the server/client side system of minecraft can explain what I could not here.

[Pilzinsel64]

@Shaddaaa Ah, I see what you mean with glider is off in SP. xD Well this the simlest solution I found, so don't wonder me.

I took a look to your code. Looks fine (better and more logical) and you don't need an open setter. Tested MP & SP, seems to work well. (Making it public via a setter method should be fine btw but I try to prevent this where it's not needed normally.)

So, please make a PR. I'll close this then and approve yours. And thank you a lot for your investigation! :)