Spot light usd lux lights #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Aug 8, 2023
ericmehl
force-pushed
the
spotLight-usdLuxLights
branch
2 times, most recently
from
34c094a
to
dd522a0
Compare
|
We should be good on CI now, it passed a minute ago but I noticed a mistake |
Two things are needed to make `OptionalValuePlug`, used by USDLuxLights, compatible with `ParameterInspector` and `LightTool` : 1. Recognize when the `source` is coming from an `OptionalValuePlug` and only return it as the source when the plug is enabled. 2. Recognize when the parameter does not exist in the shader data and don't return an `editFunction()` if so. Previously we were not checking if a parameter existed for a shader, so we would return an `editFunction` that when called, would raise an exception when it would be called via `acquireEdit()`. ( `::parameterValue` in `EditScopeAlgo` raises the exception. )
johnhaddon
force-pushed
the
spotLight-usdLuxLights
branch
from
dd522a0
to
647a2a9
Compare
Thanks Eric, LGTM. I've squashed and am about to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for USDLux lights to the light tool.
Checklist