Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot light usd lux lights #5416

Merged

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    0ba208e View commit details
    Browse the repository at this point in the history
  2. ParameterInspector : Light OptionalValuePlug

    Two things are needed to make `OptionalValuePlug`, used by USDLuxLights,
    compatible with `ParameterInspector` and `LightTool` :
    
    1. Recognize when the `source` is coming from an `OptionalValuePlug`
    and only return it as the source when the plug is enabled.
    2. Recognize when the parameter does not exist in the shader data and
    don't return an `editFunction()` if so.
    
    Previously we were not checking if a parameter existed for a shader, so
    we would return an `editFunction` that when called, would raise an
    exception when it would be called via `acquireEdit()`.
    ( `::parameterValue` in `EditScopeAlgo` raises the exception. )
    ericmehl authored and johnhaddon committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a862325 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4208941 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    647a2a9 View commit details
    Browse the repository at this point in the history