SetFilterUI : Support dropping set names onto nodes #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Apr 15, 2024
4 tasks
ericmehl
force-pushed
the
dragSetEditorToFilter
branch
from
dad406e to
663b643
Compare
ericmehl
force-pushed
the
dragSetEditorToFilter
branch
from
663b643 to
b5f3d6d
Compare
|
Looks like CI is happy, so ready for a new look! |
johnhaddon
reviewed
Apr 17, 2024
johnhaddon
reviewed
Apr 17, 2024
johnhaddon
reviewed
Apr 17, 2024
ericmehl
force-pushed
the
dragSetEditorToFilter
branch
3 times, most recently
from
dab8c8b to
f1ecf94
Compare
|
My latest push fixes the outstanding notes, and also simplifies how we handle expressions with logic vs. simple lists of sets. Now any boolean or hierarchy operators will disable dropping onto the node. This was done because the desired end result of dropping onto such an expression is either not entirely clear, or quite complicated to integrate with the logic operations. |
ericmehl
force-pushed
the
dragSetEditorToFilter
branch
from
731e877 to
fe93658
Compare
|
I pushed one small fixup just now that moves the changelog entry for this PR to the |
johnhaddon
force-pushed
the
dragSetEditorToFilter
branch
from
fe93658 to
a51de92
Compare
|
Thanks Eric - squashed and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to drag a list of set names onto a
FilterSceneProcessorderived node, or aSetFilternode. As with dragging path lists, if the node does not have aSetFilter, one will be created and populated with the contents of the drag.The handling of set expressions with anything but a simple list of set names is very simple for now. I'm just wrapping the existing expression in parenthesis before adding to the expression. As we talked about today, eventually it would be nice to parse the expression and come up with a cleaner expression.
Checklist