Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeWidget : Dispose of completion menu on activatedSignal #5910

Merged
merged 1 commit into from
Jun 19, 2024
Merged

CodeWidget : Dispose of completion menu on activatedSignal #5910

merged 1 commit into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. CodeWidget : Dispose of completion menu on activatedSignal 

    This fixes the "`Ctrl`+`Return` doesn't always commit my changes" issue reported recently. If the completion menu was visible while `Ctrl`+`Return` was pressed changes would not be committed due to the loss of focus workaround in `CodeWidget._emitEditingFinished()`. Or in the case of a widget in a PlugPopup, the changes would not be committed and the popup would dismiss...

This was particularly apparent with overlapping set names such as "LGT" and "LGT:ALL" and entering the shorter "LGT" set into a SetExpressionPlugValueWidget in a PlugPopup. Typing "LGT" would leave the completion menu up for "LGT:ALL", and then pressing `Ctrl`+`Return` would dismiss the popup without committing the change while often leaving the completion menu still visible.
    @murraystevenson
    murraystevenson committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    772d736 View commit details
    Browse the repository at this point in the history