VisualiserTool Primitive Variable Menu #6181
Conversation
There was a problem hiding this comment.
Thanks Eric - helping folks find the things they want is definitely a good thing. I've highlighted a couple of bugs inline that should be pretty straightforward to take care of.
Having this as a submenu of the right-click menu still feels a bit out of the way to me in practice, and I'm not sure how we'll fit the "Vertex ID" mode in with it. I think it might be nice to write a custom PlugValueWidget hosting a MenuButton with your menu (and only your menu) on it - what do you think?
ericmehl
force-pushed
the
visualiserToolPrimVarMenu
branch
from
3d656e1 to
53aa8ed
Compare
| def __setDataName( self, value, *unused ) : | ||
|
|
||
| self.getPlug().setValue( value ) | ||
| self.__menuButton.setText( value ) |
There was a problem hiding this comment.
This should really be done in an _updateFromValues() override, so that the button is updated no matter how the plug's value is changed.
There was a problem hiding this comment.
Fixed and squashed into c78be9e. I guess using the --- string in case someone tries to assign multiple different values to the plug is appropriate? I'm not sure it entirely makes sense, maybe we should error instead?
There was a problem hiding this comment.
You'll only get multiple different values when the widget has been configured to edit multiple plugs at once, which won't happen for this widget. But I think an empty string will now be replaced with ---, which probably doesn't make sense? Maybe None would be better?
There was a problem hiding this comment.
While I'm nitpicking, let's also move _updateFromValues() above the private methods.
There was a problem hiding this comment.
That sounds good. Changed to None and moved the method above the private methods in dfe1c9a
Changes.md
Outdated
| @@ -16,7 +16,7 @@ Features | |||
| - Inference : Loads ONNX models and performs inference using an array of input tensors. | |||
| - ImageToTensor : Converts images to tensors for use with the Inference node. | |||
| - TensorToImage : Converts tensors back to images following inference. | |||
| - VisualiserTool : Added tool to 3D viewer for visualising primitive variables on meshes. | |||
| - VisualiserTool : Added tool to 3D viewer for visualising primitive variables on meshes. A list of available variable names for the current selection is available from the `dataName` context menu. | |||
There was a problem hiding this comment.
This will need moving to the 1.5.x.x section since we've released 1.5.2.0 now.
There was a problem hiding this comment.
Fixed and squashed into c78be9e
ericmehl
force-pushed
the
visualiserToolPrimVarMenu
branch
from
53aa8ed to
c78be9e
Compare
ericmehl
force-pushed
the
visualiserToolPrimVarMenu
branch
from
c78be9e to
dfe1c9a
Compare
This adds a handy sub-menu to the context menu for the
VisualisationTool.dataNameplug listing all the primitive variables that can be visualised by the tool for the current selection.Checklist