Address review comment

Signed-off-by: Gagan Juneja <[email protected]>
Gaganjuneja · Sep 6, 2023 · df58f96 · df58f96
1 parent edf60a3
commit df58f96
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/...r/src/internalClusterTest/java/org/opensearch/discovery/single/SingleNodeDiscoveryIT.java b/...r/src/internalClusterTest/java/org/opensearch/discovery/single/SingleNodeDiscoveryIT.java
@@ -114,7 +114,6 @@ public Path nodeConfigPath(int nodeOrdinal) {
             assertThat(second.nodes().getSize(), equalTo(1));
             assertThat(first.nodes().getClusterManagerNodeId(), not(equalTo(second.nodes().getClusterManagerNodeId())));
             assertThat(first.metadata().clusterUUID(), not(equalTo(second.metadata().clusterUUID())));
-            internalCluster().stopNodesAndClients();
         }
     }
 
@@ -179,7 +178,6 @@ public Path nodeConfigPath(int nodeOrdinal) {
                 final ClusterState first = internalCluster().getInstance(ClusterService.class).state();
                 assertThat(first.nodes().getSize(), equalTo(1));
                 assertBusy(() -> mockAppender.assertAllExpectationsMatched());
-                internalCluster().stopNodesAndClients();
             }
         }
     }

diff --git a/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java b/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
@@ -1915,10 +1915,6 @@ private void stopNodesAndClient(NodeAndClient nodeAndClient) throws IOException
         stopNodesAndClients(Collections.singleton(nodeAndClient));
     }
 
-    public void stopNodesAndClients() throws IOException {
-        stopNodesAndClients(nodes.values());
-    }
-
     private synchronized void stopNodesAndClients(Collection<NodeAndClient> nodeAndClients) throws IOException {
         final Set<String> excludedNodeIds = excludeClusterManagers(nodeAndClients);
 

diff --git a/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java b/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java
@@ -157,6 +157,7 @@
 import org.opensearch.test.disruption.ServiceDisruptionScheme;
 import org.opensearch.test.store.MockFSIndexStore;
 import org.opensearch.test.telemetry.MockTelemetryPlugin;
+import org.opensearch.test.telemetry.tracing.StrictCheckSpanProcessor;
 import org.opensearch.test.transport.MockTransportService;
 import org.opensearch.transport.TransportInterceptor;
 import org.opensearch.transport.TransportRequest;
@@ -2295,7 +2296,9 @@ public static void afterClass() throws Exception {
                 INSTANCE.printTestMessage("cleaning up after");
                 INSTANCE.afterInternal(true);
                 checkStaticState(true);
+                StrictCheckSpanProcessor.validateTracingStateOnShutdown();
             }
+
         } finally {
             SUITE_SEED = null;
             currentCluster = null;

diff --git a/test/framework/src/main/java/org/opensearch/test/OpenSearchTestCase.java b/test/framework/src/main/java/org/opensearch/test/OpenSearchTestCase.java
@@ -130,7 +130,6 @@
 import org.opensearch.search.MockSearchService;
 import org.opensearch.test.junit.listeners.LoggingListener;
 import org.opensearch.test.junit.listeners.ReproduceInfoPrinter;
-import org.opensearch.test.telemetry.tracing.StrictCheckSpanProcessor;
 import org.opensearch.threadpool.ThreadPool;
 import org.opensearch.transport.TransportService;
 import org.opensearch.transport.nio.MockNioTransportPlugin;
@@ -627,7 +626,6 @@ public void log(StatusData data) {
     protected static void checkStaticState(boolean afterClass) throws Exception {
         if (afterClass) {
             MockPageCacheRecycler.ensureAllPagesAreReleased();
-            StrictCheckSpanProcessor.validateTracingStateOnShutdown();
         }
         MockBigArrays.ensureAllArraysAreReleased();