Create MarkerCommands #8
Conversation
| alert.set(true) | ||
| }).withTimeout(5.0).andThen(Commands.runOnce({ | ||
| alert.set(false) |
There was a problem hiding this comment.
Is this just for logging purposes? If so, will an alert be shown to the drivers?
There was a problem hiding this comment.
This is for logging purposes. The driver calls this command when there's issues and it'll save the timestamp.
There was a problem hiding this comment.
I wonder if it might distract the driver. Because we do want to use the alerts minimally so the drivers will actually look at them when critical errors happen.
Also, where is the timestamp saved?
There was a problem hiding this comment.
If we open the timestamp in advantagescope we can see when it exists and when it doesn't
There was a problem hiding this comment.
Okay. Still I'm not sure why you need this as an alert? Why is using log() not sufficient?
If the problem is that multiple messages will overlap, you can just add the timestamp or an index number to the message.
There was a problem hiding this comment.
When we do it as alert we can make it show up in advantagescope. If we log it we'll have to search through the logs for when it happend.
There was a problem hiding this comment.
- You still log it
- The messages log is used by team code only, it shouldn't have other types of messages.
- Errors and warnings highlighted by AdvantageScope.
- You can use another message entry for the driver markers.
I'm aware of the alert feature 🙂 but this is not the use case here, they should only be used to notify the drivers.
No description provided.