-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new educational sections in english #2704
feat: add new educational sections in english #2704
Conversation
GaloyMoney/earn#24 #2704 GaloyMoney/blink#3306 |
Thanks for the pr! Two pieces of feedback:
|
6101635
to
eb9aacd
Compare
done |
cc6f10e
to
07d3020
Compare
e4d3259
to
e44421f
Compare
Thanks for making the requested changes! Was your intention to just add the resources to the mobile application or to make them live within the app? Currently the sections are not live and there requires a little more configuration to make it live. |
fb2fc61
to
38af938
Compare
Yes, I want them visible in the app. I see now I missed adding the new quiz
questions to app/screens/earns-screen/sections.ts...That's different in our
fork, sorry about that! Just pushed a change. I think they should be
showing up now?
…On Thu, Oct 12, 2023 at 6:12 PM UncleSamtoshi ***@***.***> wrote:
Thanks for making the requested changes! Was your intention to just add
the resources to the mobile application or to make them live within the
app? Currently the sections are not live and there requires a little more
configuration to make it live.
—
Reply to this email directly, view it on GitHub
<#2704 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXA4563EZB7TBRQ62AJHC3X7CBODANCNFSM6AAAAAA5V6H77U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
38af938
to
6b679da
Compare
hey @UncleSamtoshi - I'm finally able to get a simulator for the upstream app and can confirm the new sections are showing up now. |
Thanks for making those changes. Can you run |
I belive this PR needs to be merged before the current pr. I am waiting to merge to approve that pr till I get confirmation from the team that we can effectively prevent fake accounts from getting the increased rewards. |
1a70b37
to
52a61bd
Compare
52a61bd
to
a7c2352
Compare
check-code and tests are now passing. |
This adds the new education sections from https://github.com/galoymoney/earn.