Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing scripts #24

Merged
merged 13 commits into from
Oct 12, 2023
Merged

Add processing scripts #24

merged 13 commits into from
Oct 12, 2023

Conversation

leesalminen
Copy link
Contributor

  • bin/update-json.sh
    this script will take the input and output in json format that matches the requirements for the mobile app. NOTE: this format matches Bitcoin Jungle's fork of Galoy and looks like it needs some minor adjustments for Blink currently.

  • bin/translate-combination.sh
    process the text through google translate - helpful tool to translate.

- bin/update-json.sh
this script will take the input and output in json format that matches the requirements for the mobile app

- bin/translate-combination.sh
process the text through google translate
@leesalminen
Copy link
Contributor Author

I've updated the json output script to match blink's current structure.

@leesalminen
Copy link
Contributor Author

#24
This PR adds a new shell script that processes the source yaml files to the appropriate json structure for the mobile app

GaloyMoney/blink-mobile#2704
This one adds the English translation for the new sections
I'm not currently able to run this in the simulator but it matches up to the work I did in our fork that does work so should be good? YOLO

GaloyMoney/blink#3306
This one adds the point allowances to the back end for the new sections

Copy link
Contributor

@UncleSamtoshi UncleSamtoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the ball forward on this! I left two comments.

chapter-101-bitcoin-what-is-it/101-combined.json Outdated Show resolved Hide resolved
bin/update-json.sh Show resolved Hide resolved
@UncleSamtoshi
Copy link
Contributor

Looks great, thanks Lee!

@UncleSamtoshi UncleSamtoshi merged commit fe3c53b into GaloyMoney:main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants