chore(core): move kratos e2e tests and delete e2e dir #3943
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8533381 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
| 8533381 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/e2e/servers/kratos.spec.ts | View secret |
| 8533381 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/services/kratos/identity.spec.ts | View secret |
| 8533381 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/e2e/servers/kratos.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/e2e/servers/kratos.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | 1cb8283 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/services/kratos/identity.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/services/kratos/identity.spec.ts | View secret |
| 8533382 | Triggered | Generic High Entropy Secret | ca20f97 | core/api/test/unit/domain/authentication/index.spec.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
vindard
force-pushed
the
move-kratos-e2e-2
branch
from
eda5671 to
f66247b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vindard
force-pushed
the
move-kratos-e2e-2
branch
3 times, most recently
from
b02b98e to
ca09d52
Compare
vindard
force-pushed
the
move-kratos-e2e-2
branch
from
ca09d52 to
9535eb7
Compare
vindard
force-pushed
the
move-kratos-e2e-2
branch
5 times, most recently
from
98f7fbc to
d6c3899
Compare
vindard
force-pushed
the
move-kratos-e2e-2
branch
from
d6c3899 to
6de586f
Compare
vindard
force-pushed
the
move-kratos-e2e-2
branch
from
6de586f to
99d1594
Compare
| @@ -87,7 +87,7 @@ export LOG_LEVEL="info" | |||
|
|
|||
| export KRATOS_MASTER_USER_PASSWORD="passwordHardtoFindWithNumber123" | |||
| export KRATOS_PG_HOST="localhost" | |||
| export KRATOS_PG_PORT="5433" | |||
| export KRATOS_PG_PORT="5432" | |||
There was a problem hiding this comment.
I dont see changes in docker compose.. are you sure about this?
There was a problem hiding this comment.
Oh right, this assumes we now target tilt deps and not docker-compose deps anymore. It's probably irrelevant since we're planning to find a way to remove .env and have all the things we would normally need for local dev come through buck either way.
We have some cleaning up of docs, deps, envs and local workflows to do after this PR
| @@ -88,7 +88,7 @@ export LOG_LEVEL="info" | |||
| export KRATOS_MASTER_USER_PASSWORD="passwordHardtoFindWithNumber123" | |||
| export KRATOS_ADMIN_URL="http://localhost:4434" | |||
| export KRATOS_PG_HOST="localhost" | |||
| export KRATOS_PG_PORT="5433" | |||
| export KRATOS_PG_PORT="5432" | |||
| @@ -35,6 +35,20 @@ export const getSupportedCountries = ({ | |||
| return countries | |||
| } | |||
|
|
|||
| export const getNextPageToken = (link: string): string | undefined => { | |||
There was a problem hiding this comment.
this is specific to service implementation, should not be in the core domain
| @@ -24,21 +24,39 @@ type IdentityPhone = IdentityBase & { | |||
| phone: PhoneNumber | |||
| email: undefined | |||
| emailVerified: undefined | |||
|
|
|||
| username?: undefined | |||
There was a problem hiding this comment.
maybe I am missing something but kratos is not updated when the user sets the username.. so do we have a process syncing this?
There was a problem hiding this comment.
This is different. It's added to IdentityPhone/IdentityEmail/IdentityPhoneEmail just to satisfy the AnyIdentity interface and it really only has meaning in IdentityDeviceAccount where the type is IdentityUsername and not our user's account usernames
No description provided.