-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): move kratos e2e tests and delete e2e dir #3943
Changes from all commits
1cb8283
8eac77d
e81cf02
591e425
c7298f2
639a2e9
6aa5fcb
06a14ae
bc0caba
8d2c0bb
eb864ab
9625f24
3d61434
5d701c7
3b78375
7f52e18
b756780
b9fdd04
e282bb9
99d1594
ca20f97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,7 +88,7 @@ export LOG_LEVEL="info" | |
export KRATOS_MASTER_USER_PASSWORD="passwordHardtoFindWithNumber123" | ||
export KRATOS_ADMIN_URL="http://localhost:4434" | ||
export KRATOS_PG_HOST="localhost" | ||
export KRATOS_PG_PORT="5433" | ||
export KRATOS_PG_PORT="5432" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
export OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:4318" | ||
# TODO: rename to OTEL_SERVICE_NAME | ||
|
@@ -97,7 +97,7 @@ export TRACING_SERVICE_NAME="galoy-dev" | |
|
||
export MATTERMOST_WEBHOOK_URL="https://chat.galoy.io/hooks/sometoken" | ||
|
||
export KRATOS_PG_CON="postgres://dbuser:secret@localhost:5433/default?sslmode=disable" | ||
export KRATOS_PG_CON="postgres://dbuser:secret@localhost:5432/default?sslmode=disable" | ||
|
||
export UNSECURE_DEFAULT_LOGIN_CODE="000000" | ||
export UNSECURE_IP_FROM_REQUEST_OBJECT=true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,21 +24,39 @@ type IdentityPhone = IdentityBase & { | |
phone: PhoneNumber | ||
email: undefined | ||
emailVerified: undefined | ||
|
||
username?: undefined | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe I am missing something but kratos is not updated when the user sets the username.. so do we have a process syncing this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is different. It's added to |
||
} | ||
|
||
type IdentityEmail = IdentityBase & { | ||
phone: undefined | ||
email: EmailAddress | ||
emailVerified: boolean | ||
|
||
username?: undefined | ||
} | ||
|
||
type IdentityPhoneEmail = IdentityBase & { | ||
phone: PhoneNumber | ||
email: EmailAddress | ||
emailVerified: boolean | ||
|
||
username?: undefined | ||
} | ||
|
||
type IdentityDeviceAccount = IdentityBase & { | ||
username: IdentityUsername | ||
|
||
phone?: undefined | ||
email?: undefined | ||
emailVerified?: undefined | ||
} | ||
|
||
type AnyIdentity = IdentityPhone | IdentityEmail | IdentityPhoneEmail | ||
type AnyIdentity = | ||
| IdentityPhone | ||
| IdentityEmail | ||
| IdentityPhoneEmail | ||
| IdentityDeviceAccount | ||
|
||
type Session = { | ||
identity: AnyIdentity | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see changes in docker compose.. are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, this assumes we now target tilt deps and not docker-compose deps anymore. It's probably irrelevant since we're planning to find a way to remove .env and have all the things we would normally need for local dev come through buck either way.
We have some cleaning up of docs, deps, envs and local workflows to do after this PR