Initial code creation. working on creating review schema and model setup and handler functions #21

adescoteaux1 · 2024-09-19T18:52:00Z

Description

Created a review Schema, handler, and model. Created the routes and wokred on implementing geting reviews and albums by user ID. Still a WIP and going to work on get everything working 9/20

Issue

(https://github.com//issues/14#issue-2526654150)

How Has This Been Tested?

Pagination:

Screenshots:

…tup and handler functions

…teNU/platnm into get_song_and_album_review Offset and limit fix

backend/internal/models/review.go

backend/internal/service/server.go

aaronkim218 · 2024-09-21T00:31:00Z

backend/internal/storage/postgres/schema/review.go

+	var reviews []*models.Review
+	for rows.Next() {
+		var review models.Review
+		var userID, mediaID, mediaType, desc, rating *string


dont think u need these temp vals. can just bind straight to fields of review struct

ya see this from the pgx docs

aaronkim218 · 2024-09-21T00:36:03Z

backend/internal/service/handler/review.go

+	//offsetParam := r.URL.Query().Get("offset")
+	//review, err := h.reviewRepository.GetReviewsByID(id, mediaType, c.Context())
+
+	var offset int


maybe move offset limit stuff to helper func to clean up handler func. or create utils package with this functionality since we may need in the future

backend/internal/service/handler/review.go

gaikwadsid · 2024-09-23T14:25:02Z

backend/internal/storage/postgres/storage.go

@@ -40,6 +41,7 @@ func ConnectDatabase(host, user, password, dbname, port string) *pgxpool.Pool {

 func NewRepository(db *pgxpool.Pool) *storage.Repository {
 	return &storage.Repository{
-		User: user.NewUserRepository(db),
+		User:   user.NewUserRepository(db),
+		Review: review.NewReviewRepository(db),


We can use the same import here for the NewReviewRepository(db). Honestly might be better to change user into something more universal.

…tup and handler functions

Resolving comments

commit 722541a Author: Dessy Dusichka <[email protected]> Date: Mon Sep 23 21:09:01 2024 -0400 Adding docs on making schema changes, updating contributing docs (#26) * docs updates * remove unnecessary info commit 403be01 Author: Luisa <[email protected]> Date: Mon Sep 23 19:23:39 2024 -0400 Get reviews for user (#20) Me when reviews are retrieved by user ids commit ec0ab7a Merge: f33718a 22b4ed7 Author: gaikwadsid <[email protected]> Date: Mon Sep 23 17:18:14 2024 -0400 Merge pull request #24 from GenerateNU/rest_of_schema Rest of schema commit f33718a Author: aahil nishad <[email protected]> Date: Mon Sep 23 16:21:22 2024 -0400 Create new review endpoint & review types. (#27) * feat: add create review endpoint * refactor: fix error handling for create review * refactor: make handlers more modular * fix: update query to handle edge cases * fix: check userid is valid when creating review * fix: make pr changes * revert update to og script --------- Co-authored-by: aaronkimbrooktec <[email protected]> Co-authored-by: ddusichka <[email protected]> commit 7ae380f Author: Dessy Dusichka <[email protected]> Date: Mon Sep 23 00:10:47 2024 -0400 Add nix scripts to lint and run frontend (#28) * add scripts for frontend * allow console for now and remove test action * make prettier happy * one more try commit 22b4ed7 Author: gaikwadsid <[email protected]> Date: Sun Sep 22 18:57:24 2024 -0400 Example for new script commit e99e4ea Author: gaikwadsid <[email protected]> Date: Sun Sep 22 00:09:46 2024 -0400 Connected Frontend to Backend (#23) * Connected Frontend to Backend * Fixed lint? * Fix lint * Fix lint * Fix lint * Fix lint * Fix lint * Fix lint? * Fix lint * Fix lint * prettier fix? * lint fix * fix lint. * Deleted .env file --------- Co-authored-by: ddusichka <[email protected]> commit e783ffe Author: ddusichka <[email protected]> Date: Sun Sep 22 00:04:59 2024 -0400 pause frontend tests commit 551b292 Author: gaikwadsid <[email protected]> Date: Sat Sep 21 21:49:17 2024 -0400 Fixed syntax errrors commit df13718 Author: Dessy Dusichka <[email protected]> Date: Sat Sep 21 14:48:00 2024 -0400 Update pull_request_template.md commit 4f7e72c Merge: 9816b83 70dd930 Author: Dessy Dusichka <[email protected]> Date: Sat Sep 21 11:17:01 2024 -0400 Merge pull request #22 from GenerateNU/env-help-bump Move Task scripts to Nix scripts commit cefc909 Author: gaikwadsid <[email protected]> Date: Fri Sep 20 22:17:35 2024 -0400 Added data into the tables commit 9816b83 Merge: 09b17a6 5cfb658 Author: Dessy Dusichka <[email protected]> Date: Fri Sep 20 13:27:13 2024 -0400 Merge pull request #18 from GenerateNU/spotify-oauth-v2 feat: spotify oauth commit 70dd930 Author: Jackson Terrill <[email protected]> Date: Fri Sep 20 00:49:03 2024 -0400 Move Task scripts to Nix scripts commit b663684 Author: gaikwadsid <[email protected]> Date: Thu Sep 19 18:38:06 2024 -0400 Added rest of schema commit 5cfb658 Merge: 540e431 09b17a6 Author: aaronkimbrooktec <[email protected]> Date: Thu Sep 19 17:41:00 2024 -0400 Merge remote-tracking branch 'origin' into spotify-oauth-v2 commit 540e431 Author: aaronkimbrooktec <[email protected]> Date: Thu Sep 19 17:40:53 2024 -0400 refactor: make oauth sessionvalue store available to all providers commit 09b17a6 Author: gaikwadsid <[email protected]> Date: Thu Sep 19 17:22:18 2024 -0400 Update pull_request_template.md commit f98e84a Author: gaikwadsid <[email protected]> Date: Thu Sep 19 17:20:53 2024 -0400 Update pull_request_template.md commit d8d6996 Author: aaronkimbrooktec <[email protected]> Date: Thu Sep 19 16:15:53 2024 -0400 refactor: rename and reorganize some things commit 1fe560a Author: garrettladley <[email protected]> Date: Thu Sep 19 11:47:29 2024 -0400 feat: back to sessions commit 5752469 Author: ddusichka <[email protected]> Date: Thu Sep 19 10:48:35 2024 -0400 make favicon error go away commit 1264a6b Author: garrettladley <[email protected]> Date: Thu Sep 19 09:50:06 2024 -0400 feat: don't keep track of challenge on our end, clean up, and TODO resolved commit 01f9218 Merge: eab21a4 ead556c Author: Garrett Ladley <[email protected]> Date: Wed Sep 18 23:45:49 2024 -0400 Merge branch 'main' into spotify-oauth-v2 commit ead556c Author: Aaron Kim <[email protected]> Date: Wed Sep 18 23:45:17 2024 -0400 feat: add central error handling (#19) commit eab21a4 Author: garrettladley <[email protected]> Date: Wed Sep 18 23:17:37 2024 -0400 nit: make stateValue fields unexported commit d9c9ddd Author: garrettladley <[email protected]> Date: Wed Sep 18 23:16:02 2024 -0400 fix: lint? commit 9f2b184 Author: garrettladley <[email protected]> Date: Wed Sep 18 23:15:12 2024 -0400 fix: lint? commit 079f0be Author: garrettladley <[email protected]> Date: Wed Sep 18 23:11:40 2024 -0400 fix: lint? commit 71ccfab Author: garrettladley <[email protected]> Date: Wed Sep 18 23:10:14 2024 -0400 fix: lint? commit 11ce351 Author: garrettladley <[email protected]> Date: Wed Sep 18 23:05:16 2024 -0400 fix: check err value of set commit f93510b Author: garrettladley <[email protected]> Date: Wed Sep 18 23:00:54 2024 -0400 feat: kv with state as the key and verifier x challenge as the value commit 72ef134 Author: aaronkimbrooktec <[email protected]> Date: Wed Sep 18 17:33:52 2024 -0400 feat: spotify oauth commit 0a567be Author: Dessy Dusichka <[email protected]> Date: Wed Sep 18 20:52:41 2024 -0400 Create pull_request_template.md commit 648ad3f Merge: 37c4fad 7c69270 Author: gaikwadsid <[email protected]> Date: Tue Sep 17 22:30:00 2024 -0400 Merge pull request #16 from GenerateNU/add-schema Setting up database tables and seed data commit 7c69270 Author: ddusichka <[email protected]> Date: Tue Sep 17 22:15:37 2024 -0400 add unique constraint commit 13c9527 Author: ddusichka <[email protected]> Date: Tue Sep 17 15:00:01 2024 -0400 update ID types and seed data commit c1feea9 Author: ddusichka <[email protected]> Date: Mon Sep 16 22:55:43 2024 -0400 setting up schema and seed data

…song_and_album_review

adescoteaux1 and others added 24 commits September 19, 2024 14:49

Initial code creation. working on creating review schema and model se…

749843e

…tup and handler functions

adding reviewRepo to storage

17dedd7

fixes?

a01df99

types

47b54db

scehma names

245cacb

schema work?

8a9f0ca

?

8c05b46

trying

a1db69a

check

71a92b0

?

d3d233c

making it work?

1bc8ae5

fixed

911b51b

offset and limit fix

477606f

Merge branch 'get_song_and_album_review' of https://github.com/Genera…

98ef2d6

…teNU/platnm into get_song_and_album_review Offset and limit fix

removing the if

3ed5403

types

cd3aceb

working?

26ecef6

Removing strconv

91f1d13

Fixing server to get functions correct

2239d0b

type converts

4f3b671

lint fixes

f33a18c

pagination

92337d3

Trying to debug

edc144a

still not working

2fbfbdc

aaronkim218 reviewed Sep 21, 2024

View reviewed changes

garrettladley reviewed Sep 23, 2024

View reviewed changes

backend/internal/service/handler/review.go Outdated Show resolved Hide resolved

garrettladley reviewed Sep 23, 2024

View reviewed changes

backend/internal/service/handler/review.go Outdated Show resolved Hide resolved

garrettladley reviewed Sep 23, 2024

View reviewed changes

backend/internal/service/handler/review.go Outdated Show resolved Hide resolved

gaikwadsid reviewed Sep 23, 2024

View reviewed changes

Initial code creation. working on creating review schema and model se…

43d19b5

…tup and handler functions

adescoteaux1 added 8 commits September 23, 2024 21:21

adding reviewRepo to storage

abe06f8

Resolving comments

e6a8791

Resolving comments

Merge branch 'main' of https://github.com/GenerateNU/platnm into get_…

4eb2216

…song_and_album_review

lint

4464316

Lots of updates, mostly working now, made pagination a helper

f50e1c8

Pagination working

7cdfaf6

merge main in?

b2f0ec9

adescoteaux1 closed this Sep 28, 2024

adescoteaux1 deleted the get_song_and_album_review branch September 28, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial code creation. working on creating review schema and model setup and handler functions #21

Initial code creation. working on creating review schema and model setup and handler functions #21

adescoteaux1 commented Sep 19, 2024 •

edited

Loading

aaronkim218 Sep 21, 2024

garrettladley Sep 23, 2024

aaronkim218 Sep 21, 2024

gaikwadsid Sep 23, 2024

Initial code creation. working on creating review schema and model setup and handler functions #21

Initial code creation. working on creating review schema and model setup and handler functions #21

Conversation

adescoteaux1 commented Sep 19, 2024 • edited Loading

Description

Issue

How Has This Been Tested?

Screenshots:

aaronkim218 Sep 21, 2024

Choose a reason for hiding this comment

garrettladley Sep 23, 2024

Choose a reason for hiding this comment

aaronkim218 Sep 21, 2024

Choose a reason for hiding this comment

gaikwadsid Sep 23, 2024

Choose a reason for hiding this comment

adescoteaux1 commented Sep 19, 2024 •

edited

Loading