Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code creation. working on creating review schema and model setup and handler functions #21
Initial code creation. working on creating review schema and model setup and handler functions #21
Changes from 24 commits
749843e
17dedd7
a01df99
47b54db
245cacb
8a9f0ca
8c05b46
a1db69a
71a92b0
d3d233c
1bc8ae5
911b51b
477606f
98ef2d6
3ed5403
cd3aceb
26ecef6
91f1d13
2239d0b
4f3b671
f33a18c
92337d3
edc144a
2fbfbdc
43d19b5
abe06f8
e6a8791
6d75f10
4eb2216
4464316
f50e1c8
7cdfaf6
b2f0ec9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe move offset limit stuff to helper func to clean up handler func. or create utils package with this functionality since we may need in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont think u need these temp vals. can just bind straight to fields of review struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya see this from the pgx docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need log here. we added central error handling so if u just return error, fiber will catch it and log it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the same import here for the NewReviewRepository(db). Honestly might be better to change user into something more universal.