SAC-14 Update Tag Patch #35
Conversation
garrettladley
requested review from
a team,
akshayd2020,
michael-brennan2005 and
DOOduneye
and removed request for
a team
backend/src/controllers/tag.go
Outdated
| return err | ||
| } | ||
|
|
||
| return c.SendStatus(fiber.StatusNoContent) |
There was a problem hiding this comment.
should we be returning a no content status code? I guess it's fair but giving some key back for success to the frontend might be good @alderwhiteford mr error code god whats your opinion?
There was a problem hiding this comment.
From what I've seen on the semantics sending a 204 (fiber.StatusNoContent), it means "although the server successfully processes the request, there's no additional content or response payload body that needs to be returned to the client. In essence, a 204 status code conveys 'I've done what you asked, and there's no more information to give you.'" (Abstract API)
There was a problem hiding this comment.
Not to be the contrarian but what would we send back? What information would the frontend need on update or delete? From my perspective, just whether it happened, or not
No description provided.