Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAC-14 Update Tag Patch #35
SAC-14 Update Tag Patch #35
Changes from 14 commits
ba564ea
6127a86
1f7eedf
4659deb
8233edd
ae5e6bd
5e70ee7
f7622e8
ebd3a8d
67aa29d
3e9945a
fa44d3b
ed18a94
71ec057
1c282bd
bff3a71
8ada9be
377330b
1d0d1c8
4bb96ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be returning a no content status code? I guess it's fair but giving some key back for success to the frontend might be good @alderwhiteford mr error code god whats your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've seen on the semantics sending a 204 (
fiber.StatusNoContent
), it means "although the server successfully processes the request, there's no additional content or response payload body that needs to be returned to the client. In essence, a 204 status code conveys 'I've done what you asked, and there's no more information to give you.'" (Abstract API)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be the contrarian but what would we send back? What information would the frontend need on update or delete? From my perspective, just whether it happened, or not