improvement: Improve genezio addClass output #919
Conversation
|
Please review this @andreia-oca |
src/commands/addClass.ts
Outdated
| @@ -40,7 +40,9 @@ export async function addClassCommand(classPath: string, classType: string) { | |||
| const classExtension = className.split(".").pop(); | |||
|
|
|||
| if (!classExtension || className.split(".").length < 2) { | |||
| throw new UserError("Please provide a class name with a valid class extension."); | |||
| throw new UserError( | |||
| "Please provide a class name with a valid class extension (.ts, .js, or .dart.", | |||
There was a problem hiding this comment.
Please, do not hardcode these values here.
We keep adding support for more programming languages and it would be hard to maintain this piece of code if it's harcoded.
You can use and parse these list [1] of supported extensions to form the error message.
[1] https://github.com/Genez-io/genezio/blob/main/src/utils/languages.ts#L2
|
Hey @andreia-oca |
| @@ -40,7 +40,9 @@ export async function addClassCommand(classPath: string, classType: string) { | |||
| const classExtension = className.split(".").pop(); | |||
|
|
|||
| if (!classExtension || className.split(".").length < 2) { | |||
| throw new UserError("Please provide a class name with a valid class extension."); | |||
| throw new UserError( | |||
| `Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`, | |||
There was a problem hiding this comment.
| `Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`, | |
| `Please provide a class name with a valid class extension. Currently supporting: ${supportedExtensions}`, |
There was a problem hiding this comment.
It seems that supportedExtensionsString is not declared, I think you want to use supportedExtensions instead. Feel free to commit my suggestion.
|
This PR seems inactive - I will close it. If there are any changes to the branch, we can reopen it. |
Pull Request Template
Type of change
Description
This PR improves Genezio addClass output
Checklist