Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Improve genezio addClass output #919

Closed
wants to merge 2 commits into from
Closed

improvement: Improve genezio addClass output #919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140df26
improvement: Improve genezio addClass output
bhavyastar Mar 26, 2024
c4bb89d
improvement: Improve genezio addClass output
bhavyastar Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/commands/addClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
const classExtension = className.split(".").pop();

if (!classExtension || className.split(".").length < 2) {
throw new UserError("Please provide a class name with a valid class extension.");
throw new UserError(
`Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`,

Check failure on line 44 in src/commands/addClass.ts

View workflow job for this annotation

GitHub Actions / build (18, ubuntu-latest) 

Cannot find name 'supportedExtensionsString'. Did you mean 'supportedExtensions'?

Check failure on line 44 in src/commands/addClass.ts

View workflow job for this annotation

GitHub Actions / build (20, ubuntu-latest) 

Cannot find name 'supportedExtensionsString'. Did you mean 'supportedExtensions'?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`,
`Please provide a class name with a valid class extension. Currently supporting: ${supportedExtensions}`,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that supportedExtensionsString is not declared, I think you want to use supportedExtensions instead. Feel free to commit my suggestion.

);
}

// check if class is supported
Expand Down
Loading