-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…j() instead of Event obj (in deleteGunDB() function)
MarianoAmado
requested review from
sirpy,
serdiukov-o-nordwhale and
mauriguz
December 28, 2020 15:16
@sirpy @serdiukov-o-nordwhale |
…ith promise rejection
@MarianoAmado i've adjusted the code according to the IndexedDB API docs. |
serdiukov-o-nordwhale
approved these changes
Dec 29, 2020
mauriguz
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Sentry Non-Error promise rejection error: passing Error obj to rej() instead of Event obj in
deleteGunDB()
functionComment on a related issue: getsentry/sentry-javascript#2546 (comment)
About #2830
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: