Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Bug) Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type #2851

Merged
merged 11 commits into from
Jan 3, 2021
Merged

(Bug) Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type #2851

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ffbddd
Fix Sentry Non-Error promise rejection error: passing Error obj to re…
MarianoAmado Dec 28, 2020
3a66733
add handle IndexedDB exception according to the API docs, return it w…
serdiukov-o-nordwhale Dec 29, 2020
289fd8f
Apply suggestions from code review
serdiukov-o-nordwhale Dec 29, 2020
09f6e5d
add promisify idb calls
serdiukov-o-nordwhale Dec 29, 2020
9ba4c2a
restore suppress rejections on open / transaction calls
serdiukov-o-nordwhale Dec 29, 2020
8c90f19
fix last adjustments
serdiukov-o-nordwhale Dec 29, 2020
4cd9074
fix bring back supress
serdiukov-o-nordwhale Dec 29, 2020
8e82444
Update useDeleteAccountDialog.js
serdiukov-o-nordwhale Dec 29, 2020
6398edf
Update useDeleteAccountDialog.js
serdiukov-o-nordwhale Dec 29, 2020
45b45a8
deleteGunDB(): revert refactor
MarianoAmado Dec 29, 2020
1c89459
deleteGunDB() improvement: on error, rejecting with the real error
MarianoAmado Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/hooks/useDeleteAccountDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import LoadingIcon from '../../components/common/modal/LoadingIcon'
import retryImport from '../utils/retryImport'
import restart from '../utils/restart'
import { isMobileNative } from '../utils/platform'

const log = logger.child({ from: 'useDeleteAccountDialog' })

export const deleteGunDB = () => {
Expand All @@ -25,7 +26,7 @@ export const deleteGunDB = () => {
const objectStoreRequest = objectStore.clear()

objectStoreRequest.onsuccess = res
objectStoreRequest.onerror = rej
objectStoreRequest.onerror = () => rej(objectStoreRequest.error)
}
})
}
Expand Down