remove window.gtag function #54
Conversation
duh, will do 🤦 |
| @@ -75,14 +79,15 @@ export interface GTag { | |||
| (fn: 'config', opt: 'reset'): void; | |||
| } | |||
|
|
|||
| export interface GoogleAnalyticsApi { | |||
There was a problem hiding this comment.
this is technically a breaking change for the types
it's probably safe as i can't imagine anyone besides Nuxt Scripts using it but please be mindful of these changes down the line
There was a problem hiding this comment.
correct, Nuxt Script is currently the only framework using the types from here
| "strategy": "worker", | ||
| "location": "head", | ||
| "action": "append", | ||
| "key": "gtag" | ||
| }, | ||
| { | ||
| "code": "window.dataLayers=window.dataLayers||{};window.dataLayers['{{dataLayerName}}']=window.dataLayers['{{dataLayerName}}']||[];window.gtag=function gtag(){window.dataLayers['{{dataLayerName}}'].push(arguments);};window.gtag('js',new Date());window.gtag('config','{{id}}')", | ||
| "params": ["id", "dataLayerName"], | ||
| "code": "window['{{l}}']=window['{{l}}']||[];window['{{l}}'].push({'js':new Date()});window['{{l}}'].push({'config':'{{id}}'})", |
|
happy to have this merged as is but we definitely want to avoid breaking changes like this in the future between patch / minors |
Absolutely, breaking changes are possible here, since we're still implementing it and no other framework depends on these changes at the moment. |
The issue is that you have versioned the package as stable so package managers will update end users' versions whenever you do a patch/minor as third-party-capital is a dependency of Nuxt Scripts. We can lock the TPC version though as a workaround on our end. |
should resolve #53
@kara