Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPStan level to 6 and fix violations and bump minimum PHP to 7.2 #69

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

felixarntz
Copy link
Collaborator

This PR performs some updates to improve code quality and modernize the codebase a little:

  • Update PHPStan level to 6 and fix all the violations it flags (which lead to better type safety).
  • Bump minimum PHP version required to 7.2 (there's no good reason to support 7.0, and e.g. void return type doesn't work on 7.0).
  • Update Composer dependencies.
  • Use latest versions in GitHub workflows.

Copy link
Collaborator

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spiffy!

@felixarntz felixarntz merged commit 177d4fd into main Aug 29, 2024
6 checks passed
@felixarntz felixarntz deleted the update/phpstan-level-6 branch September 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants