Add e2e tests for tpu-provisioner #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstogner
changed the title
nstogner
force-pushed
the
tpu-provisioner--e2e-tests
branch
from
51723ae
to
00ad9b9
Compare
Comment on lines
+208
to
+232
| tpu_v4_2x2x2 = tpuConfig{ | ||
| accelerator: "tpu-v4-podslice", | ||
| topoX: 2, | ||
| topoY: 2, | ||
| topoZ: 2, | ||
| chipsPerNode: 4, | ||
| sliceCount: 1, | ||
| } | ||
| tpu_v4_2x2x4 = tpuConfig{ | ||
| accelerator: "tpu-v4-podslice", | ||
| topoX: 2, | ||
| topoY: 2, | ||
| topoZ: 4, | ||
| chipsPerNode: 4, | ||
| sliceCount: 1, | ||
| } | ||
|
|
||
| tpu_v5e_2x4 = tpuConfig{ | ||
| accelerator: "tpu-v5-lite-podslice", | ||
| topoX: 2, | ||
| topoY: 4, | ||
| chipsPerNode: 4, | ||
| sliceCount: 2, | ||
| } | ||
| */ |
There was a problem hiding this comment.
Are these commented out intentionally or was it meant to be temporarily commented out for your testing?
|
|
||
| func newJobset(name string, c tpuConfig, uniqueNodeSelector bool) *jobset.JobSet { | ||
| nodeSelectors := map[string]string{ | ||
| "cloud.google.com/gke-tpu-accelerator": c.accelerator, |
There was a problem hiding this comment.
Can we define the various labels in this file as constants somewhere
Comment on lines
+34
to
+38
| var cf struct { | ||
| o sync.Once | ||
| m sync.RWMutex | ||
| f []func() | ||
| } |
There was a problem hiding this comment.
The variable names for this struct and its fields are unclear to me,
later in the code when the variables are used it's a bit confusing what the variable is referring to.
Can we make them more descriptive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a cluster, installs tpu-provisioner, and then runs test JobSets against the cluster.