Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support vLLM openai entrypoint benchmarking script #793

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

Edwinhr716
Copy link
Member

@Edwinhr716 Edwinhr716 commented Aug 31, 2024

Currently the benchmarking script only works with the regular entrypoint of vllm. Since the benchmarking suite builds uses openai entrypoint instead, changed it to support that entrypoint
.

Copy link
Collaborator

@vivianrwu vivianrwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For jetstream, can you change max_tokens: 1 to max_tokens: output_len under the benchmark_serving.py script? Other than that, lgtm for jetstream side changes!

@annapendleton annapendleton merged commit c872599 into GoogleCloudPlatform:main Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants