-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool: fix the types.go
template
#3608
Conversation
/assign @yuwenma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Suggest to add a flag to skip adding the observedState
. Some resources have specialties and this could cause confusions
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
From my experience, I typically decide whether to keep or remove |
Rebased to resolve a merge conflict. |
/lgtm |
f09d1f0
into
GoogleCloudPlatform:master
Not sure if there was a merge error, but I noticed this while generating the new resources.