Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: fix the types.go template #3608

Merged
merged 1 commit into from
Feb 5, 2025
Merged

tool: fix the types.go template #3608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apis/iap/v1alpha1/iapsettings_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ type IAPSettingsStatus struct {
// ObservedState *IAPSettingsObservedState `json:"observedState,omitempty"`
}

// IAPSettingsSpec defines the desired state of IAPSettings
// +kcc:proto=google.cloud.iap.v1.IapSettings
// IAPSettingsObservedState is the state of the IAPSettings resource as most recently observed in GCP.
// +kcc:proto=google.cloud.iap.v1.IapSettings
// NOTYET: there is no output only field
// type IAPSettingsObservedState struct {
// }
Expand Down
1 change: 0 additions & 1 deletion apis/managedkafka/v1alpha1/cluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ type ManagedKafkaClusterStatus struct {
ObservedState *ManagedKafkaClusterObservedState `json:"observedState,omitempty"`
}

// ManagedKafkaClusterSpec defines the desired state of ManagedKafkaCluster
// ManagedKafkaClusterObservedState is the state of the ManagedKafkaCluster resource as most recently observed in GCP.
// +kcc:proto=google.cloud.managedkafka.v1.Cluster
type ManagedKafkaClusterObservedState struct {
Expand Down
3 changes: 1 addition & 2 deletions apis/managedkafka/v1alpha1/topic_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,8 @@ type ManagedKafkaTopicStatus struct {
// ObservedState *ManagedKafkaTopicObservedState `json:"observedState,omitempty"`
}

// ManagedKafkaTopicSpec defines the desired state of ManagedKafkaTopic
// +kcc:proto=google.cloud.managedkafka.v1.Topic
// ManagedKafkaTopicObservedState is the state of the ManagedKafkaTopic resource as most recently observed in GCP.
// +kcc:proto=google.cloud.managedkafka.v1.Topic
// NOTYET: the resource does not have any output only fields
// type ManagedKafkaTopicObservedState struct {
// }
Expand Down
3 changes: 1 addition & 2 deletions dev/tools/controllerbuilder/template/apis/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,10 @@ type {{ .Kind }}Status struct {
ObservedState *{{ .Kind }}ObservedState ` + "`" + `json:"observedState,omitempty"` + "`" + `
}

// {{ .Kind }}Spec defines the desired state of {{ .Kind }}
// {{ .Kind }}ObservedState is the state of the {{ .Kind }} resource as most recently observed in GCP.
{{- if .KindProtoTag }}
// +kcc:proto={{ .KindProtoTag }}
{{- end }}
// {{ .Kind }}ObservedState is the state of the {{ .Kind }} resource as most recently observed in GCP.
type {{ .Kind }}ObservedState struct {
}

Expand Down
Loading