-
Notifications
You must be signed in to change notification settings - Fork 2
Filetree Gemstone update #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add Pharo32-8.0
add Pharo32-8.0 to travis.yml
Cleanup: Remove ConfigurationOfBitmapCharacterSet
Cleanups like formatting and lint checking
Remove BitmapCharacterSet class>>#inspectorClass
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil
Cleanup: Remove ConfigurationOfBitmapCharacterSet
Cleanups like formatting and lint checking
Remove BitmapCharacterSet class>>#inspectorClass
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil For GemStone: - changed the category to match the Pharo one - renamed -Core to -Base package to match the upstream - ignoring manifest changes - ignoring symbols->string changes as this was already done
|
@tukanos, could you add the gemstone ci info from the ci.yml on the gemstone branch, so we can validate the code against gemstone before the merge? I'd recommend changing the and add any of the gemstone versions that you intend to run on ... I haven't put mac-os on the list, because gemstone and macos have had some issues in recent versions that need TLC to get the tests to work -- namely you have to turn off native code ... it's possible that 3.7.4.3 disables native code for so it might not be an issue for that version ... so if you want mac-os tested then go ahead and add it so it can made to work ... Since this is a GemStone-specific port, I don't think that it's necessary to test the Pharo versions .. unless that is something that you want ... Probably a good idea to just start with 3.7.4.3 and ubuntu just to get the tests passing ... I've re-enabled the workflow, so CI jobs should run automatically ... |
|
Oh I forget to mention that on line 34 in ci.yml, the |
|
@dalehenrich Thank you for the heads-up. I have updated the yml file according to your instructions. CI jobs do not seem to start, probably the change needs to be merged first. |
I have tried to merge all the changed code between gemstone branch and the master at upstream. I have updated the master from the upstream.