Skip to content

Conversation

@tukanos
Copy link

@tukanos tukanos commented Sep 19, 2025

I have tried to merge all the changed code between gemstone branch and the master at upstream. I have updated the master from the upstream.

vonbecmann and others added 30 commits March 9, 2021 23:30
Cleanup: Remove ConfigurationOfBitmapCharacterSet
Cleanups like formatting and lint checking
Remove BitmapCharacterSet class>>#inspectorClass
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil

BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil
Cleanup: Remove ConfigurationOfBitmapCharacterSet
Cleanups like formatting and lint checking
Remove BitmapCharacterSet class>>#inspectorClass
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil

BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil

For GemStone:
- changed the category to match the Pharo one
- renamed -Core to -Base package to match the upstream
- ignoring manifest changes
- ignoring symbols->string changes as this was already done
@dalehenrich
Copy link
Member

@tukanos, could you add the gemstone ci info from the ci.yml on the gemstone branch, so we can validate the code against gemstone before the merge?

I'd recommend changing the os and smalltalk list to:

        os: [ ubuntu-latest ]
        smalltalk: [ GemStone64-3.7.4.3 ]

and add any of the gemstone versions that you intend to run on ... I haven't put mac-os on the list, because gemstone and macos have had some issues in recent versions that need TLC to get the tests to work -- namely you have to turn off native code ... it's possible that 3.7.4.3 disables native code for so it might not be an issue for that version ... so if you want mac-os tested then go ahead and add it so it can made to work ...

Since this is a GemStone-specific port, I don't think that it's necessary to test the Pharo versions .. unless that is something that you want ...

Probably a good idea to just start with 3.7.4.3 and ubuntu just to get the tests passing ...

I've re-enabled the workflow, so CI jobs should run automatically ...

@dalehenrich
Copy link
Member

Oh I forget to mention that on line 34 in ci.yml, the runs-on: ubuntu-20.04 should be changed to runs-on: ubuntu-latest .. this runs a hook that lists ci tests results in one of our slack channels ...

@tukanos
Copy link
Author

tukanos commented Sep 29, 2025

@dalehenrich Thank you for the heads-up. I have updated the yml file according to your instructions. CI jobs do not seem to start, probably the change needs to be merged first.

@tukanos tukanos closed this Sep 29, 2025
@tukanos tukanos deleted the gemstoneUpdate branch September 29, 2025 08:00
@tukanos tukanos mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants