-
Notifications
You must be signed in to change notification settings - Fork 3
[Backend] NodeJS - week 1 #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments based on my discovery with #159 and past experiences.
I like the structure though, especially in the session materials!
6fbceaa
to
a44dd31
Compare
@marcorichetta to review the progress here and summarise what's left, before we continue |
courses/backend/node/week2/README.md
Outdated
For more research, check the following resource: | ||
|
||
- [What is REST: a simple explanation for beginners](https://medium.com/extend/what-is-rest-a-simple-explanation-for-beginners-part-1-introduction-b4a072f8740f) | ||
|
||
- [@NoerGitKat (lots of web app clones/examples to learn from)](https://github.com/NoerGitKat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Candidate for preparation.md
First, you should demonstrate the SQL injection and that it for instance is possible to drop/delete the `contacts` table with the `sort` query parameter. | ||
You can for instance demonstrate this with a screen recording and include it in the PR description. | ||
|
||
After having demonstrated the SQL injection vulnerability, the goal is then to fix the issue by updating `app.js`. | ||
|
||
**Hint:** the `multipleStatements: true` part in the configuration indicates how you can use the vulnerability. The configuration should not be changed though, the SQL injection should be fixed by making changes in the `/api/contacts` route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made sense for MySQL. Knex with sqlite doesn't accept that config.
We should review how to replicate or change the way of showing an SQL injection. There's something similar in the backend/databases module
Done!
|
Co-authored-by: Marco Richetta <[email protected]>
Co-authored-by: Marco Richetta <[email protected]>
0caae9d
to
c5c14e6
Compare
@adamblanchard I have two doubts to clear. I went according to the plan: https://github.com/HackYourFuture-CPH/program/blob/fe5da8a4eef91d759ed80b31d9d7b1bcd8be5d83/contributing/proposals/js-node-restructure.md
I think I'm most doubtful about the above two, otherwise the week 1 could be up for review :) |
Description
Status
Content check or update
Week 1
module-materials
Week 2 -> Work moved to [Backend] NodeJS - week 2 #199
Generic
Review for traces of MySQL
Review assignments for outdated material
Remove
teach-live-coding
referencesRemove homework upload references
Remove
nodemon
references(Optional) Review relevance to Foundation/intro-to-nodejs, link overlapping material if exists
Proposal overview
https://github.com/HackYourFuture-CPH/programme/blob/main/contributing/proposals/js-node-restructure.md#backend-specialisation