Merge pull request #19 from ahoek/feature-js-linter

Feature js linter
Harborn-digital · Mar 9, 2016 · 177143e · 177143e
2 parents bf69c09 + d8aab2f
commit 177143e
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -16,19 +16,24 @@ To use the EcmaScript 2015 (ES6) transpiling, add the following dependencies:
 npm install babel-preset-es2015 gulp-babel gulp-plumber --save-dev
 ```
 
+To enable the javascript linter, add eslint:
+```bash
+npm install gulp-eslint --save-dev
+```
+
 Example configuration:
 ```json
     "javascript": {
         "items": [
             {
                 "src": [
-                    "bower_components/babel-polyfill/browser-polyfill.js",
                     "javascript/app.js"
                 ],
                 "outputname": "app.js",
                 "dest": "../../web/assets/javascript/",
                 "options": {},
-                "es2015": true
+                "es2015": true,
+                "lint": true
             }
         ],
     }

diff --git a/package.json b/package.json
@@ -12,6 +12,7 @@
     "gulp-babel": "^6.1.2",
     "gulp-concat": "^2.6.0",
     "gulp-consolidate": "^0.2.0",
+    "gulp-eslint": "^2.0.0",
     "gulp-iconfont": "^6.0.0",
     "gulp-if": "^2.0.0",
     "gulp-image-data-uri": "^1.2.1",

diff --git a/tasks/javascript.js b/tasks/javascript.js
@@ -2,6 +2,30 @@
 
 module.exports = function (gulp, config) {
     return function () {
+        /**
+         * Add linter with configuration to an item
+         *
+         * @param {type} result
+         * @param {type} item
+         * @returns {unresolved}
+         */
+        var addLinter = function (result, item) {
+            var eslint = require('gulp-eslint');
+            var eslintOptions = {
+                extends: 'eslint:recommended',
+                envs: ["browser", "jquery", "prototypejs"],
+            };
+
+            if (item.es2015 === true) {
+                eslintOptions.envs.push("es6");
+            }
+
+            result
+                .pipe(eslint(eslintOptions))
+                .pipe(eslint.format())
+
+            return result;
+        };
 
         var sourcemaps = require('gulp-sourcemaps');
         var util = require('gulp-util');
@@ -18,6 +42,10 @@ module.exports = function (gulp, config) {
             var result = gulp.src(item.src)
                 .pipe(sourcemaps.init());
 
+            if (item.lint) {
+                addLinter(result, item);
+            }
+
             if (item.es2015 === true) {
                 // Transpile es2015
                 result