-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p2p): remove sync-v1 code and disable tests #1197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | feat/remove-sync-v1 |
Testbed | ubuntu-22.04 |
🚨 1 Alert
Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 1.48 (-10.25%) | 1.49 (100.28%) |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 1.48 (-10.25%) | 1.49 (100.28%) | 1.82 (81.59%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
- Coverage 85.02% 83.63% -1.40%
==========================================
Files 323 320 -3
Lines 25133 24540 -593
Branches 3859 3762 -97
==========================================
- Hits 21370 20524 -846
- Misses 3028 3255 +227
- Partials 735 761 +26 ☔ View full report in Codecov by Sentry. |
1 task
msbrogli
requested changes
Jan 9, 2025
745f933
to
260087b
Compare
glevco
requested changes
Jan 17, 2025
fee2cb4
to
85784bd
Compare
glevco
previously approved these changes
Jan 23, 2025
85784bd
to
aede16a
Compare
glevco
approved these changes
Jan 23, 2025
msbrogli
approved these changes
Jan 23, 2025
This was referenced Feb 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've had sync-v1 in unsafe mode for a while and bridge nodes are on their way out, also all supported releases have sync-v2 on by default, and as far as we know there's no one using sync-v1 anymore.
Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged