Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): remove sync-v1 code and disable tests #1197

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jansegre
Copy link
Member

Motivation

We've had sync-v1 in unsafe mode for a while and bridge nodes are on their way out, also all supported releases have sync-v2 on by default, and as far as we know there's no one using sync-v1 anymore.

Acceptance Criteria

  • Remove sync-v1 agent;
  • Remove cli flags that enable sync-v1 directly or indirectly;
  • Remove enable/disable sync-v1 methods from builder;
  • Remove sync-v1 tests;
  • Move sync-bridge tests to the normal classes and remove the separate classes;
  • No behavior should change apart from not being able to use sync-v1;
  • No tests should be removed unless it's specific to sync-v1;

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Dec 23, 2024
@jansegre jansegre requested a review from msbrogli as a code owner December 23, 2024 22:01
Copy link

github-actions bot commented Dec 23, 2024

🐰 Bencher Report

Branchfeat/remove-sync-v1
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚨 alert (🔔)
🚷 threshold
1.48
(-10.25%)
1.49
(100.28%)
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚨 view alert (🔔)
🚷 view threshold
1.48
(-10.25%)
1.49
(100.28%)
1.82
(81.59%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (90fddc7) to head (aede16a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/builder/cli_builder.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   85.02%   83.63%   -1.40%     
==========================================
  Files         323      320       -3     
  Lines       25133    24540     -593     
  Branches     3859     3762      -97     
==========================================
- Hits        21370    20524     -846     
- Misses       3028     3255     +227     
- Partials      735      761      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/event/test_event_simulation_scenarios.py Outdated Show resolved Hide resolved
tests/p2p/test_sync.py Show resolved Hide resolved
tests/p2p/test_whitelist.py Outdated Show resolved Hide resolved
tests/tx/test_tx_serialization.py Show resolved Hide resolved
@jansegre jansegre requested a review from glevco January 16, 2025 21:32
@jansegre jansegre force-pushed the feat/remove-sync-v1 branch from 745f933 to 260087b Compare January 16, 2025 21:51
hathor/builder/cli_builder.py Show resolved Hide resolved
tests/event/test_event_simulation_scenarios.py Outdated Show resolved Hide resolved
tests/p2p/test_sync.py Show resolved Hide resolved
tests/simulation/base.py Show resolved Hide resolved
tests/simulation/test_simulator_itself.py Outdated Show resolved Hide resolved
tests/sysctl/test_p2p.py Outdated Show resolved Hide resolved
@jansegre jansegre force-pushed the feat/remove-sync-v1 branch 2 times, most recently from fee2cb4 to 85784bd Compare January 17, 2025 18:13
glevco
glevco previously approved these changes Jan 23, 2025
@jansegre jansegre merged commit cb26fa9 into master Jan 23, 2025
9 of 10 checks passed
@jansegre jansegre deleted the feat/remove-sync-v1 branch January 23, 2025 20:38
This was referenced Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants