[hxb] Signature dependencies - part 2 #11659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
reviewed
May 8, 2024
Simn
reviewed
May 8, 2024
Also only load those imports when reading the whole module
kLabz
force-pushed
the
hxb_sig_deps_continued
branch
from
52dbe39 to
06a3dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11650 broke with some projects, because
MDRchunk was pulling modules that were not tracked in signature dependencies (so ignored when checking dependencies, which could be missing or invalidated).MDRchunk was introduced in 7603234 because of #11493 (comment)New implementation only adds
MDepFromImportdependencies there, and does not resolve those when hxb reader is in "signature only" mode.