Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-644 - refact: remove references for offer.price field over offer.cost #2684

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,17 @@ import { motion } from 'framer-motion'
import { useTranslation } from 'next-i18next'
import React, { ReactNode, useState } from 'react'
import { ChevronIcon, Text, theme } from 'ui'
import { ProductOfferFragment } from '@/services/apollo/generated'
import { useFormatter } from '@/utils/useFormatter'

type Props = { defaultOpen: boolean; price: string; children: ReactNode }
type Props = { defaultOpen: boolean; cost: ProductOfferFragment['cost']; children: ReactNode }

export const CartEntryCollapsible = ({ defaultOpen, price, children }: Props) => {
export const CartEntryCollapsible = ({ defaultOpen, cost, children }: Props) => {
const [open, setOpen] = useState(defaultOpen)
const { t } = useTranslation('cart')
const formatter = useFormatter()

const hasDiscountApplied = cost.discount.amount > 0

return (
<Collapsible.Root open={open} onOpenChange={setOpen}>
Expand All @@ -19,7 +24,12 @@ export const CartEntryCollapsible = ({ defaultOpen, price, children }: Props) =>
<ChevronIcon color={theme.colors.textTertiary} size="1rem" />
</Trigger>
<PriceFlex>
<Text>{price}</Text>
{hasDiscountApplied && (
<Text color="textSecondary" strikethrough={true}>
{formatter.monthlyPrice(cost.gross)}
</Text>
)}
<Text>{formatter.monthlyPrice(cost.net)}</Text>
</PriceFlex>
</DetailsHeader>
<CollapsibleContent forceMount>
Expand Down Expand Up @@ -56,6 +66,7 @@ const PriceFlex = styled.div({
display: 'flex',
alignItems: 'center',
height: '100%',
gap: theme.space.xs,
})

const Trigger = styled(Collapsible.Trigger)({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { useEditProductOffer } from '@/components/CartPage/useEditProductOffer'
import { Pillow } from '@/components/Pillow/Pillow'
import { SpaceFlex } from '@/components/SpaceFlex/SpaceFlex'
import { CartFragmentFragment } from '@/services/apollo/generated'
import { useFormatter } from '@/utils/useFormatter'
import { CartEntry } from '../CartInventory.types'
import { RemoveEntryDialog } from '../RemoveEntryDialog'
import { CartEntryCollapsible } from './CartEntryCollapsible'
Expand All @@ -24,7 +23,6 @@ export const CartEntryItem = ({ defaultOpen = false, ...props }: Props) => {
const { shopSessionId, readOnly, onRemove, ...cartEntry } = props
const { title: titleLabel, cost, pillow } = cartEntry
const { t } = useTranslation('cart')
const formatter = useFormatter()

const [editProductOffer, editState] = useEditProductOffer()
const handleConfirmEdit = () => {
Expand All @@ -51,7 +49,7 @@ export const CartEntryItem = ({ defaultOpen = false, ...props }: Props) => {

<Space y={1}>
<Layout.Details>
<CartEntryCollapsible defaultOpen={defaultOpen} price={formatter.monthlyPrice(cost)}>
<CartEntryCollapsible defaultOpen={defaultOpen} cost={cost}>
<DetailsSheet {...cartEntry} />
</CartEntryCollapsible>
</Layout.Details>
Expand Down
12 changes: 11 additions & 1 deletion apps/store/src/components/CartInventory/CartEntryOfferItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export const CartEntryOfferItem = ({ shopSessionId, product, offer }: CartOfferI

if (!show) return null

const hasDiscountApplied = offer.cost.discount.amount > 0

return (
<Layout.Main>
<Layout.Pillow>
Expand Down Expand Up @@ -95,7 +97,14 @@ export const CartEntryOfferItem = ({ shopSessionId, product, offer }: CartOfferI
</Space>
</Layout.Actions>

<Layout.Price>{formatter.monthlyPrice(offer.price)}</Layout.Price>
<Layout.Price>
{hasDiscountApplied && (
<Text color="textSecondary" strikethrough={true}>
{formatter.monthlyPrice(offer.cost.gross)}
</Text>
)}
{formatter.monthlyPrice(offer.cost.net)}
</Layout.Price>
</Layout.Main>
)
}
Expand Down Expand Up @@ -142,6 +151,7 @@ const Layout = {
gridArea: GRID_AREAS.Price,
display: 'flex',
alignItems: 'center',
gap: theme.space.xs,
}),
Content: styled.div({ gridArea: GRID_AREAS.Content }),
Actions: styled.div({ gridArea: GRID_AREAS.Actions }),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const getCartEntry = (item: ShopSession['cart']['entries'][number]): Cart
return {
offerId: item.id,
title: item.variant.product.displayNameFull,
cost: item.price,
cost: item.cost,
startDate: hasCancellation ? undefined : convertToDate(item.startDate),
pillow: {
src: item.variant.product.pillowImage.src,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const CartInventory = ({ shopSessionId, cart, readOnly = false }: Props)
key={item.id}
offerId={item.id}
title={item.variant.product.displayNameFull}
cost={item.price}
cost={item.cost}
pillow={{
src: item.variant.product.pillowImage.src,
alt: item.variant.product.pillowImage.alt ?? '',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { CartFragmentFragment } from '@/services/apollo/generated'
import { CartFragmentFragment, ProductOfferFragment } from '@/services/apollo/generated'
import { Money } from '@/utils/formatter'

export type CartEntry = {
offerId: string
title: string
cost: Money
cost: ProductOfferFragment['cost']
startDate?: Date | null
pillow: { src: string; alt?: string }
documents: CartFragmentFragment['entries'][number]['variant']['documents']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const DeductibleSelector = ({ offers, selectedOffer, onValueChange }: Pro
if (offer.deductible) {
levels.push({
id: offer.id,
price: offer.price,
price: offer.cost.net,
title: offer.deductible.displayName,
description: offer.deductible.tagline,
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const ProductTierSelector = ({ offers, selectedOffer, onValueChange }: Pr
key={offer.id}
value={offer.id}
title={offer.variant.displayName}
price={formatter.monthlyPrice(offer.price)}
price={formatter.monthlyPrice(offer.cost.net)}
description={getVariantDescription(offer.variant.typeOfContract)}
/>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export const PurchaseForm = () => {

notifyProductAdded({
name: productData.displayNameFull,
price: formatter.monthlyPrice(item.price),
price: formatter.monthlyPrice(item.cost.net),
pillowSrc: productData.pillowImage.src,
description:
!item.cancellation.requested ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { ProductOfferFragment } from '@/services/apollo/generated'

export const getOffersByPrice = (offers: Array<ProductOfferFragment>) => {
return [...offers].sort((a, b) => {
if (a.price.amount < b.price.amount) return -1
if (a.price.amount > b.price.amount) return 1
if (a.cost.net.amount < b.cost.net.amount) return -1
if (a.cost.net.amount > b.cost.net.amount) return 1
return 0
})
}
16 changes: 13 additions & 3 deletions apps/store/src/graphql/OfferRecommendationFragment.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,18 @@ fragment OfferRecommendation on ProductOffer {
displayNameFull
}
}
price {
amount
currencyCode
cost {
gross {
amount
currencyCode
}
net {
amount
currencyCode
}
discount {
amount
currencyCode
}
}
}
4 changes: 0 additions & 4 deletions apps/store/src/graphql/ProductOfferFragment.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ fragment ProductOffer on ProductOffer {
url
}
}
price {
amount
currencyCode
}
cost {
gross {
amount
Expand Down
14 changes: 7 additions & 7 deletions apps/store/src/services/Tracking/Tracking.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type TrackingProductData = {
}

type TrackingOffer = {
price: ProductOfferFragment['price']
cost: ProductOfferFragment['cost']
variant: {
typeOfContract: ProductOfferFragment['variant']['typeOfContract']
product: {
Expand Down Expand Up @@ -140,8 +140,8 @@ export class Tracking {
const userData = await getLegacyUserData(this.context)
const eventData = {
offerData: {
insurance_price: offer.price.amount,
currency: offer.price.currencyCode as string,
insurance_price: offer.cost.gross.amount,
currency: offer.cost.gross.currencyCode as string,

insurance_type: offer.variant.typeOfContract,
flow_type: offer.variant.product.name,
Expand Down Expand Up @@ -304,13 +304,13 @@ const offerToEcommerceEvent = ({
return {
event,
ecommerce: {
value: offer.price.amount,
currency: offer.price.currencyCode,
value: offer.cost.gross.amount,
guilhermespopolin marked this conversation as resolved.
Show resolved Hide resolved
currency: offer.cost.gross.currencyCode,
items: [
{
item_id: offer.variant.product.id,
item_name: offer.variant.product.displayNameFull,
price: offer.price.amount,
price: offer.cost.gross.amount,
item_variant: offer.variant.typeOfContract,
...(source && { item_list_id: source }),
},
Expand Down Expand Up @@ -341,7 +341,7 @@ const cartToEcommerceEvent = (
items: cart.entries.map((entry) => ({
item_id: entry.variant.product.id,
item_name: entry.variant.product.displayNameFull,
price: entry.price.amount,
price: entry.cost.gross.amount,
variant: entry.variant.typeOfContract,
})),
},
Expand Down