Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-644 - refact: remove references for offer.price field over offer.cost #2684

Merged

Conversation

guilhermespopolin
Copy link
Contributor

@guilhermespopolin guilhermespopolin commented Jul 5, 2023

Describe your changes

  • Update codebase to rely on ProductOffer.cost over ProductOffer.price
  • General UI updates that makes usage of gross/net prices;
  • Update tracking so it makes usage of gross/net prices;

Add to cart notification - Showing net price

Screenshot 2023-07-05 at 11 17 42
notify-product-was-added


Product Tier Selector - Showing net price

Screenshot 2023-07-05 at 11 26 21


[WIP] Lacking a better image - Deductible Selector - Showing net price

deductable-tier-selector


Cart Inventory - Showing gross/net prices when applicable - only gross otherwise (For entries and recommendations)

cart-inventory

Justify why they are needed

ProductOffer.price is deprecated. We should use ProductOffer.cost instead.

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Jul 6, 2023 8:05am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 8:05am

@guilhermespopolin
Copy link
Contributor Author

guilhermespopolin commented Jul 5, 2023

@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 8c23b24 to c58ca48 Compare July 5, 2023 09:08
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/refact/remove-price-field-references branch from 462560e to 16727c9 Compare July 5, 2023 09:09
@guilhermespopolin guilhermespopolin changed the title refact: remove references for offer.price field over offer.cost GEN-644 - refact: remove references for offer.price field over offer.cost Jul 5, 2023
@notion-workspace
Copy link

Copy link
Contributor

@robinandeer robinandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one question about what to send in e-com event for tracking

Aleks mentioned that the API might not be stable -- would you say it's easy to roll-back these features or does it make sense to feature flag it?

apps/store/src/services/Tracking/Tracking.ts Show resolved Hide resolved
@guilhermespopolin
Copy link
Contributor Author

@guilhermespopolin started a stack merge that includes this pull request via Graphite.

Base automatically changed from GEN-644/feat/offer-presenter-discount to main July 6, 2023 07:58
@guilhermespopolin
Copy link
Contributor Author

Graphite rebased this pull request as part of a merge.

@guilhermespopolin guilhermespopolin force-pushed the GEN-644/refact/remove-price-field-references branch from c6fc709 to 87fad7a Compare July 6, 2023 07:58
@guilhermespopolin guilhermespopolin merged commit 689b355 into main Jul 6, 2023
3 checks passed
@guilhermespopolin
Copy link
Contributor Author

@guilhermespopolin merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants