-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEN-644 - refact: remove references for offer.price field over offer.cost #2684
GEN-644 - refact: remove references for offer.price field over offer.cost #2684
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
8c23b24
to
c58ca48
Compare
462560e
to
16727c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just one question about what to send in e-com event for tracking
Aleks mentioned that the API might not be stable -- would you say it's easy to roll-back these features or does it make sense to feature flag it?
c58ca48
to
b109c63
Compare
16727c9
to
e2c978c
Compare
e2c978c
to
7a8fe5e
Compare
2ce3dab
to
7554ad2
Compare
7a8fe5e
to
c6fc709
Compare
@guilhermespopolin started a stack merge that includes this pull request via Graphite. |
Graphite rebased this pull request as part of a merge. |
c6fc709
to
87fad7a
Compare
@guilhermespopolin merged this pull request with Graphite. |
Describe your changes
ProductOffer.cost
overProductOffer.price
Add to cart notification - Showing net price
Product Tier Selector - Showing net price
[WIP] Lacking a better image - Deductible Selector - Showing net price
Cart Inventory - Showing gross/net prices when applicable - only gross otherwise (For entries and recommendations)
Justify why they are needed
ProductOffer.price
is deprecated. We should useProductOffer.cost
instead.