Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T MEGE: GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost) #2691

Closed
wants to merge 1 commit into from

Conversation

guilhermespopolin
Copy link
Contributor

@guilhermespopolin guilhermespopolin commented Jul 5, 2023

Describe your changes

This is a contingency plan that reverts changes related with the addition of ProductOffer.cost field. It's here se it get's easy to revert in case the API shows any issues.

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 8:32am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 8:32am

@guilhermespopolin
Copy link
Contributor Author

@guilhermespopolin guilhermespopolin changed the title revert discount related changes (ProductOffer.cost) GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost) Jul 5, 2023
@notion-workspace
Copy link

@guilhermespopolin guilhermespopolin changed the title GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost) DON'T MEGE: GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost) Jul 5, 2023
Copy link
Contributor

@robinandeer robinandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🙂

@guilhermespopolin guilhermespopolin force-pushed the GEN-644/refact/remove-price-field-references branch from 7a8fe5e to c6fc709 Compare July 6, 2023 07:47
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/refact/remove-price-field-references branch from c6fc709 to 87fad7a Compare July 6, 2023 07:58
Base automatically changed from GEN-644/refact/remove-price-field-references to main July 6, 2023 07:59
@guilhermespopolin
Copy link
Contributor Author

I think we should consider the API stable now. Closing this one.

@robinandeer robinandeer deleted the GEN-644/revert/contingency-plan branch October 9, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants