-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON'T MEGE: GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost) #2691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 5, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
guilhermespopolin
changed the title
revert discount related changes (ProductOffer.cost)
GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost)
Jul 5, 2023
guilhermespopolin
changed the title
GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost)
DON'T MEGE: GEN-644 - Contigency plan: revert discount related changes (ProductOffer.cost)
Jul 5, 2023
robinandeer
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 🙂
guilhermespopolin
force-pushed
the
GEN-644/refact/remove-price-field-references
branch
from
July 6, 2023 07:47
7a8fe5e
to
c6fc709
Compare
guilhermespopolin
force-pushed
the
GEN-644/revert/contingency-plan
branch
from
July 6, 2023 07:47
289a4c5
to
ff716d3
Compare
guilhermespopolin
force-pushed
the
GEN-644/refact/remove-price-field-references
branch
from
July 6, 2023 07:58
c6fc709
to
87fad7a
Compare
Base automatically changed from
GEN-644/refact/remove-price-field-references
to
main
July 6, 2023 07:59
guilhermespopolin
force-pushed
the
GEN-644/revert/contingency-plan
branch
from
July 6, 2023 15:58
ff716d3
to
8be7e1e
Compare
guilhermespopolin
force-pushed
the
GEN-644/revert/contingency-plan
branch
from
July 7, 2023 08:35
8be7e1e
to
baefd4d
Compare
guilhermespopolin
force-pushed
the
GEN-644/revert/contingency-plan
branch
from
July 7, 2023 16:18
baefd4d
to
a698b78
Compare
guilhermespopolin
force-pushed
the
GEN-644/revert/contingency-plan
branch
from
July 10, 2023 08:10
a698b78
to
2229d1d
Compare
I think we should consider the API stable now. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a contingency plan that reverts changes related with the addition of
ProductOffer.cost
field. It's here se it get's easy to revert in case the API shows any issues.